[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D13694: Fix wrong availability of profiles and ports.
From:       Andreas Krutzler <noreply () phabricator ! kde ! org>
Date:       2018-06-26 20:26:39
Message-ID: 2c24986a2ccd1da7626a144186692c29 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

akrutzler added a comment.


  In D13694#282499 <https://phabricator.kde.org/D13694#282499>, @nicolasfella wrote:
  
  > This breaks the profile selection Combobox in the KCM.
  
  
  I'm sorry to hear that, on my system I get the same results as in the released kcm.
  
  In D13694#282499 <https://phabricator.kde.org/D13694#282499>, @nicolasfella wrote:
  
  > Assuming the idea behind your patch is correct it should be moved to the Port \
class.  
  
  Shouldn't it be enough to change the filter function from: `return \
profile.availability === Profile.Available;` to `return profile.availability !== \
Profile.Unavailable;` ?  I will update my diff to make this clearer. :)

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D13694

To: akrutzler, nicolasfella, broulik, drosca
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">akrutzler added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D13694">View Revision</a></tr></table><br \
/><div><div><blockquote style="border-left: 3px solid #8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a \
href="https://phabricator.kde.org/D13694#282499" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D13694#282499</a>, <a \
href="https://phabricator.kde.org/p/nicolasfella/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@nicolasfella</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>This breaks the profile selection Combobox \
in the KCM.</p></div> </blockquote>

<p>I&#039;m sorry to hear that, on my system I get the same results as in the \
released kcm.</p>

<blockquote style="border-left: 3px solid #8C98B8;
          color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a \
href="https://phabricator.kde.org/D13694#282499" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D13694#282499</a>, <a \
href="https://phabricator.kde.org/p/nicolasfella/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@nicolasfella</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>Assuming the idea behind your patch is \
correct it should be moved to the Port class.</p></div> </blockquote>

<p>Shouldn&#039;t it be enough to change the filter function from: <tt \
style="background: #ebebeb; font-size: 13px;">return profile.availability === \
Profile.Available;</tt> to <tt style="background: #ebebeb; font-size: 13px;">return \
profile.availability !== Profile.Unavailable;</tt> ?<br /> I will update my diff to \
make this clearer. :)</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R115 Plasma Audio Volume \
Applet</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D13694">https://phabricator.kde.org/D13694</a></div></div><br \
/><div><strong>To: </strong>akrutzler, nicolasfella, broulik, drosca<br /><strong>Cc: \
</strong>plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]