[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D13694: Fix wrong availability of profiles and ports.
From:       Nicolas Fella <noreply () phabricator ! kde ! org>
Date:       2018-06-26 9:26:58
Message-ID: 72ffafa211323e6f334c3a2054ea64a3 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

nicolasfella added a comment.


  In D13694#283089 <https://phabricator.kde.org/D13694#283089>, @drosca wrote:
  
  > In D13694#282499 <https://phabricator.kde.org/D13694#282499>, @nicolasfella \
wrote:  >
  > > This breaks the profile selection Combobox in the KCM.
  >
  >
  > How does this break that combobox? The current code is obviously wrong.
  
  
  The code for Profile is correct, the code for Port is wrong. The problem is that \
the values for Profile::Availability and Port:: Availability are not the same.  \
Profile:  0 : Not available
  everything else: Available
  
  Port:
  0: Unknown
  1: Not Available
  2: Available
  
  With this patch when a profile reports unavailable (0) it gets interpreted as \
PA_PORT_AVAILABLE_UNKNOWN and when it reports available (1) it gets interpreted as \
PA_PORT_AVAILABLE_NO

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D13694

To: akrutzler, nicolasfella, broulik, drosca
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">nicolasfella added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D13694">View Revision</a></tr></table><br \
/><div><div><blockquote style="border-left: 3px solid #8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a \
href="https://phabricator.kde.org/D13694#283089" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D13694#283089</a>, <a \
href="https://phabricator.kde.org/p/drosca/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@drosca</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid \
#8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a \
href="https://phabricator.kde.org/D13694#282499" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D13694#282499</a>, <a \
href="https://phabricator.kde.org/p/nicolasfella/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@nicolasfella</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>This breaks the profile selection Combobox \
in the KCM.</p></div> </blockquote>

<p>How does this break that combobox? The current code is obviously wrong.</p></div>
</blockquote>

<p>The code for Profile is correct, the code for Port is wrong. The problem is that \
the values for Profile::Availability and Port:: Availability are not the same.<br /> \
Profile:<br /> 0 : Not available<br />
everything else: Available</p>

<p>Port:<br />
0: Unknown<br />
1: Not Available<br />
2: Available</p>

<p>With this patch when a profile reports unavailable (0) it gets interpreted as \
PA_PORT_AVAILABLE_UNKNOWN and when it reports available (1) it gets interpreted as \
PA_PORT_AVAILABLE_NO</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R115 Plasma Audio Volume \
Applet</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D13694">https://phabricator.kde.org/D13694</a></div></div><br \
/><div><strong>To: </strong>akrutzler, nicolasfella, broulik, drosca<br /><strong>Cc: \
</strong>plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]