[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D6096: Add Wayland RemoteAccess capabilities to KRfb
From:       Jan Grulich <noreply () phabricator ! kde ! org>
Date:       2018-06-26 10:04:15
Message-ID: 00eb508d2d9de2ecc5c1ae1958aab8d6 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

jgrulich added a comment.


  I have two things I observed when implementing same in WebRTC to have this working \
in Firefox and Chrome:  
  1. Please use "Fru" for max_framerate and "Rru" for size, as it allows some \
negotiation when matching streams, I used the same in xdg-desktop-portal-kde now and \
in WebRTC and same will be used in Mutter  2. Does it always stop streaming in \
x-d-p-kde when you stop receiving stream in KRfb? I've been experiencing this in \
WebRTC where when I disconnected my consuming stream, it still kept streaming in \
x-d-p-kde which you can see in the log. I solved this by calling Session->Close() in \
WebRTC and stop streaming in x-d-p-kde when the session has been closed.

REPOSITORY
  R437 Desktop Sharing

REVISION DETAIL
  https://phabricator.kde.org/D6096

To: Kanedias, davidedmundson, graesslin, #plasma, #kde_applications
Cc: zzag, jgrulich, alexeymin, plasma-devel, ragreen, Pitel, schernikov, ZrenBot, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein


[Attachment #3 (text/html)]

<table><tr><td style="">jgrulich added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D6096">View Revision</a></tr></table><br \
/><div><div><p>I have two things I observed when implementing same in WebRTC to have \
this working in Firefox and Chrome:</p>

<ol class="remarkup-list">
<li class="remarkup-list-item">Please use &quot;Fru&quot; for max_framerate and \
&quot;Rru&quot; for size, as it allows some negotiation when matching streams, I used \
the same in xdg-desktop-portal-kde now and in WebRTC and same will be used in \
Mutter</li> <li class="remarkup-list-item">Does it always stop streaming in x-d-p-kde \
when you stop receiving stream in KRfb? I&#039;ve been experiencing this in WebRTC \
where when I disconnected my consuming stream, it still kept streaming in x-d-p-kde \
which you can see in the log. I solved this by calling Session-&gt;Close() in WebRTC \
and stop streaming in x-d-p-kde when the session has been closed.</li> \
</ol></div></div><br /><div><strong>REPOSITORY</strong><div><div>R437 Desktop \
Sharing</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D6096">https://phabricator.kde.org/D6096</a></div></div><br \
/><div><strong>To: </strong>Kanedias, davidedmundson, graesslin, Plasma, KDE \
Applications<br /><strong>Cc: </strong>zzag, jgrulich, alexeymin, plasma-devel, \
ragreen, Pitel, schernikov, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, \
eliasp, sebas, apol, mart, hein<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]