[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D6096: Add Wayland RemoteAccess capabilities to KRfb
From:       Vlad Zagorodniy <noreply () phabricator ! kde ! org>
Date:       2018-06-18 19:53:11
Message-ID: 7641f5122b5f781b568cadc11f053c91 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

zzag added inline comments.

INLINE COMMENTS

> pw_framebuffer.h:27
> +    PWFrameBuffer(WId winid, QObject *parent = nullptr);
> +    virtual ~PWFrameBuffer() override;
> +

`virtual` is redundant. (also, it doesn't make sense to have both `virtual` and \
`override`)

> pw_framebufferplugin.h:36
> +   PWFrameBufferPlugin(QObject *parent, const QVariantList &args);
> +   virtual ~PWFrameBufferPlugin() override;
> +

`virtual` is redundant.

REPOSITORY
  R437 Desktop Sharing

REVISION DETAIL
  https://phabricator.kde.org/D6096

To: Kanedias, davidedmundson, graesslin, #plasma, #kde_applications
Cc: zzag, jgrulich, alexeymin, plasma-devel, ragreen, Pitel, schernikov, ZrenBot, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein


[Attachment #3 (text/html)]

<table><tr><td style="">zzag added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D6096">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D6096#inline-71135">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">pw_framebuffer.h:27</span></div> <div \
style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span \
class="n">PWFrameBuffer</span><span class="p">(</span><span class="n">WId</span> \
<span class="n">winid</span><span class="p">,</span> <span class="n">QObject</span> \
<span style="color: #aa2211">*</span><span class="n">parent</span> <span \
style="color: #aa2211">=</span> <span class="n">nullptr</span><span \
class="p">);</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);">    <span class="n">virtual</span> <span style="color: \
#aa2211">~</span><span class="n">PWFrameBuffer</span><span class="p">()</span> <span \
class="n">override</span><span class="p">;</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt \
style="background: #ebebeb; font-size: 13px;">virtual</tt> is redundant. (also, it \
doesn&#039;t make sense to have both <tt style="background: #ebebeb; font-size: \
13px;">virtual</tt> and <tt style="background: #ebebeb; font-size: \
13px;">override</tt>)</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" \
href="https://phabricator.kde.org/D6096#inline-71136">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">pw_framebufferplugin.h:36</span></div> \
<div style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, \
&quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: both; padding: 4px 0; \
margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, \
151, .6);">   <span class="n">PWFrameBufferPlugin</span><span class="p">(</span><span \
class="n">QObject</span> <span style="color: #aa2211">*</span><span \
class="n">parent</span><span class="p">,</span> <span style="color: \
#aa4000">const</span> <span class="n">QVariantList</span> <span style="color: \
#aa2211">&amp;</span><span class="n">args</span><span class="p">);</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">   <span \
class="n">virtual</span> <span style="color: #aa2211">~</span><span \
class="n">PWFrameBufferPlugin</span><span class="p">()</span> <span \
class="n">override</span><span class="p">;</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt \
style="background: #ebebeb; font-size: 13px;">virtual</tt> is \
redundant.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R437 Desktop Sharing</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D6096">https://phabricator.kde.org/D6096</a></div></div><br \
/><div><strong>To: </strong>Kanedias, davidedmundson, graesslin, Plasma, KDE \
Applications<br /><strong>Cc: </strong>zzag, jgrulich, alexeymin, plasma-devel, \
ragreen, Pitel, schernikov, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, \
eliasp, sebas, apol, mart, hein<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]