[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D13591: Set complete vectors instead of creting them at runtime
From:       Tomaz  Canabrava <noreply () phabricator ! kde ! org>
Date:       2018-06-22 13:01:39
Message-ID: 89a1efb8dd6599bd12ef1fa1a9591b7a () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

tcanabrava updated this revision to Diff 36515.
tcanabrava edited the summary of this revision.
tcanabrava added a comment.


  - Don't realloc _pixmap vector
  - Don't use a Temporary to Copy data over
  - Fix compile
  - Don't use temporaries, compilers can optimize better this way

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13591?vs=36282&id=36515

BRANCH
  removeTemporaryReallocs

REVISION DETAIL
  https://phabricator.kde.org/D13591

AFFECTED FILES
  kdecoration/breezebutton.cpp
  kdecoration/breezesizegrip.cpp
  kstyle/breezehelper.cpp
  kstyle/breezeshadowhelper.cpp

To: tcanabrava, #breeze
Cc: ngraham, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">tcanabrava updated this revision to Diff 36515.<br \
/>tcanabrava edited the summary of this revision. <a \
href="https://phabricator.kde.org/transactions/detail/PHID-XACT-DREV-ghbcgnyu47prjrc/">(Show \
Details)</a><br />tcanabrava added a comment. </td><a style="text-decoration: none; \
padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; \
border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D13591">View Revision</a></tr></table><br \
/><div><div><ul class="remarkup-list"> <li class="remarkup-list-item">Don&#039;t \
realloc _pixmap vector</li> <li class="remarkup-list-item">Don&#039;t use a Temporary \
to Copy data over</li> <li class="remarkup-list-item">Fix compile</li>
<li class="remarkup-list-item">Don&#039;t use temporaries, compilers can optimize \
better this way</li> </ul></div></div><br /><div><strong>CHANGES TO REVISION \
SUMMARY</strong><div><div style="white-space: pre-wrap; color: #74777D;">I tested a \
bit of code with -02 to measure the speed gains of using a std::initializer_list over \
appending to a temporary and appending to temporary is around 50% slower, so I \
removed all the code that appened to temporaries for a initializer list in \
breeze.<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, \
.7);"><br /> </span></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R31 Breeze</div></div></div><br \
/><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a \
href="https://phabricator.kde.org/D13591?vs=36282&amp;id=36515">https://phabricator.kde.org/D13591?vs=36282&amp;id=36515</a></div></div><br \
/><div><strong>BRANCH</strong><div><div>removeTemporaryReallocs</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D13591">https://phabricator.kde.org/D13591</a></div></div><br \
/><div><strong>AFFECTED FILES</strong><div><div>kdecoration/breezebutton.cpp<br /> \
kdecoration/breezesizegrip.cpp<br /> kstyle/breezehelper.cpp<br />
kstyle/breezeshadowhelper.cpp</div></div></div><br /><div><strong>To: \
</strong>tcanabrava, Breeze<br /><strong>Cc: </strong>ngraham, zzag, plasma-devel, \
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, \
apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]