[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D13591: Set complete vectors instead of creting them at runtime
From:       Vlad Zagorodniy <noreply () phabricator ! kde ! org>
Date:       2018-06-18 16:56:31
Message-ID: 344cb34d214fd9bc85307e818073c123 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

zzag added inline comments.

INLINE COMMENTS

> zzag wrote in breezesizegrip.cpp:150
> Can be const.

Also, couldn't you do

  painter.drawPolygon( QVector<>{}
  );

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D13591

To: tcanabrava, #breeze
Cc: ngraham, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">zzag added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D13591">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D13591#inline-71119">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">zzag</span> wrote in <span style="color: \
#4b4d51; font-weight: bold;">breezesizegrip.cpp:150</span></div> <div style="margin: \
8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Can be \
const.</p></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p \
style="padding: 0; margin: 8px;">Also, couldn&#039;t you do</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="cpp" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span \
class="n">painter</span><span class="p">.</span><span \
class="n">drawPolygon</span><span class="p">(</span> <span \
class="n">QVector</span><span style="color: #aa2211">&lt;&gt;</span><span \
class="p">{}</span> <span \
class="p">);</span></pre></div></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R31 Breeze</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D13591">https://phabricator.kde.org/D13591</a></div></div><br \
/><div><strong>To: </strong>tcanabrava, Breeze<br /><strong>Cc: </strong>ngraham, \
zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]