[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D13194: Use the new drag handle in the Language KCM
From:       Eike Hein <noreply () phabricator ! kde ! org>
Date:       2018-06-08 0:00:53
Message-ID: 1bc24b16cc349c899b3a7b6eacfa98ba () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

hein added inline comments.

INLINE COMMENTS

> mart wrote in main.qml:77
> this explicit reparenting shouldn't be necessary (and breaks in my branch for multi \
> level kcms)

I've told you a few times now that it's been necessary for me so far, since the sheet \
doesn't appear or in bizarre locations otherwise. Did you test?

> mart wrote in main.qml:98
> is this width: necessary?

I added it because you told me several times that it's necessary now. You tell me?

> mart wrote in main.qml:184
> this shouldn't be necessary

I'll remove it soon.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13194

To: hein, mart, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">hein added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D13194">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D13194#inline-69874">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">mart</span> wrote in <span style="color: \
#4b4d51; font-weight: bold;">main.qml:77</span></div> <div style="margin: 8px 0; \
padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">this explicit \
reparenting shouldn&#039;t be necessary (and breaks in my branch for multi level \
kcms)</p></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: \
0; margin: 8px;">I&#039;ve told you a few times now that it&#039;s been necessary for \
me so far, since the sheet doesn&#039;t appear or in bizarre locations otherwise. Did \
you test?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D13194#inline-69876">View \
Inline</a><span style="color: #4b4d51; font-weight: bold;">mart</span> wrote in <span \
style="color: #4b4d51; font-weight: bold;">main.qml:98</span></div> <div \
style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: \
8px;">is this width: necessary?</p></div></div> <div style="margin: 8px 0; padding: 0 \
12px;"><p style="padding: 0; margin: 8px;">I added it because you told me several \
times that it&#039;s necessary now. You tell me?</p></div></div><br /><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D13194#inline-69877">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">mart</span> wrote in <span style="color: \
#4b4d51; font-weight: bold;">main.qml:184</span></div> <div style="margin: 8px 0; \
padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">this \
shouldn&#039;t be necessary</p></div></div> <div style="margin: 8px 0; padding: 0 \
12px;"><p style="padding: 0; margin: 8px;">I&#039;ll remove it \
soon.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D13194">https://phabricator.kde.org/D13194</a></div></div><br \
/><div><strong>To: </strong>hein, mart, davidedmundson<br /><strong>Cc: \
</strong>plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]