[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D13194: Use the new drag handle in the Language KCM
From: Marco Martin <noreply () phabricator ! kde ! org>
Date: 2018-06-07 10:24:44
Message-ID: 797878bc01125fe0aaeb3e646d38efda () localhost ! localdomain
[Download RAW message or body]
[Attachment #2 (text/plain)]
mart added inline comments.
INLINE COMMENTS
> main.qml:77
>
> parent: root.parent
>
this explicit reparenting shouldn't be necessary (and breaks in my branch for multi \
level kcms)
> main.qml:98
> + delegate: Kirigami.DelegateRecycler {
> + width: parent.width
>
is this width: necessary?
> main.qml:184
> contentItem: RowLayout {
> width: implicitWidth
>
this shouldn't be necessary
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D13194
To: hein, mart, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart
[Attachment #3 (text/html)]
<table><tr><td style="">mart added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D13194">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D13194#inline-69874">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">main.qml:77</span></div> <div style="font: \
11px/15px "Menlo", "Consolas", "Monaco", monospace; \
white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: \
0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
style="color: #aa4000">parent:</span> <span style="color: #004012">root</span><span \
class="p">.</span><span style="color: #004012">parent</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">this \
explicit reparenting shouldn't be necessary (and breaks in my branch for multi \
level kcms)</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" \
href="https://phabricator.kde.org/D13194#inline-69876">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">main.qml:98</span></div> <div style="font: \
11px/15px "Menlo", "Consolas", "Monaco", monospace; \
white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: \
0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
style="color: #aa4000">delegate:</span> <span style="color: \
#004012">Kirigami</span><span class="p">.</span><span style="color: \
#004012">DelegateRecycler</span> <span class="p">{</span> </div><div style="padding: \
0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
style="color: #aa4000">width:</span> <span style="color: #004012">parent</span><span \
class="p">.</span><span style="color: #004012">width</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">is \
this width: necessary?</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" \
href="https://phabricator.kde.org/D13194#inline-69877">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">main.qml:184</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; "> <span style="color: \
#aa4000">contentItem:</span> <span style="color: #004012">RowLayout</span> <span \
class="p">{</span> </div><div style="padding: 0 8px; margin: 0 4px; "> \
<span style="color: #aa4000">width:</span> <span style="color: \
#004012">implicitWidth</span> </div><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(251, 175, 175, .7);"> <span style="color: \
#aa4000">height:</span> <span style="color: #304a96">Math</span><span \
class="p">.</span><span style="color: #004012">max</span><span \
class="p">(</span><span style="color: #004012">implicitHeight</span><span \
class="p">,</span> <span style="color: #004012">Kirigami</span><span \
class="p">.</span><span style="color: #004012">Units</span><span \
class="p">.</span><span style="color: #004012">iconSizes</span><span \
class="p">.</span><span style="color: #004012">smallMedium</span><span \
class="p">)</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">this \
shouldn't be necessary</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D13194">https://phabricator.kde.org/D13194</a></div></div><br \
/><div><strong>To: </strong>hein, mart, davidedmundson<br /><strong>Cc: \
</strong>plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic