[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D13233: Support for the Custom color set
From:       David Edmundson <noreply () phabricator ! kde ! org>
Date:       2018-05-31 10:07:36
Message-ID: 20180531100736.1.86EBDFE2EC06E29D () phabricator ! kde ! org
[Download RAW message or body]

davidedmundson added inline comments.

INLINE COMMENTS

> plasmadesktoptheme.cpp:177
> +
> +        QPalette pal;
> +        for (auto state : { QPalette::Active, QPalette::Inactive, \
> QPalette::Disabled }) {

I don't understand this part of the patch in relation to custom color set support.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D13233

To: mart, #kirigami, broulik
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">davidedmundson added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D13233">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D13233#inline-68805">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">plasmadesktoptheme.cpp:177</span></div> \
<div style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, \
&quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: both; padding: 4px 0; \
margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, \
151, .6);">        <span class="n">QPalette</span> <span class="n">pal</span><span \
class="p">;</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);">        <span style="color: #aa4000">for</span> <span \
class="p">(</span><span style="color: #aa4000">auto</span> <span style="color: \
#a0a000">state</span> <span class="p">:</span> <span class="p">{</span> <span \
class="n">QPalette</span><span style="color: #aa2211">::</span><span \
class="n">Active</span><span class="p">,</span> <span class="n">QPalette</span><span \
style="color: #aa2211">::</span><span class="n">Inactive</span><span \
class="p">,</span> <span class="n">QPalette</span><span style="color: \
#aa2211">::</span><span class="n">Disabled</span> <span class="p">})</span> <span \
class="p">{</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I \
don&#039;t understand this part of the patch in relation to custom color set \
support.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R858 Qt Quick Controls 2: Desktop \
Style</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D13233">https://phabricator.kde.org/D13233</a></div></div><br \
/><div><strong>To: </strong>mart, Kirigami, broulik<br /><strong>Cc: \
</strong>davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]