--6a55675d664e4e2ba6380b019bf62c23
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="ascii"
Mime-Version: 1.0

davidedmundson added inline comments.

INLINE COMMENTS

> plasmadesktoptheme.cpp:177
> +
> +        QPalette pal;
> +        for (auto state : { QPalette::Active, QPalette::Inactive, QPalette::Disabled }) {

I don't understand this part of the patch in relation to custom color set support.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D13233

To: mart, #kirigami, broulik
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

--6a55675d664e4e2ba6380b019bf62c23
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html; charset="ascii"
Mime-Version: 1.0

<table><tr><td style=3D"">davidedmundson added inline comments.
</td><a style=3D"text-decoration: none; padding: 4px 8px; margin: 0 8px 8px=
; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; back=
ground-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1=
f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href=
=3D"https://phabricator.kde.org/D13233">View Revision</a></tr></table><br /=
><div><strong>INLINE COMMENTS</strong><div><div style=3D"margin: 6px 0 12px=
 0;"><div style=3D"border: 1px solid #C7CCD9; border-radius: 3px;"><div sty=
le=3D"padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style:=
 solid; border-width: 0 0 1px 0; margin: 0;"><div style=3D"color: #74777d; =
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style=3D"float=
: right; text-decoration: none;" href=3D"https://phabricator.kde.org/D13233=
#inline-68805">View Inline</a><span style=3D"color: #4b4d51; font-weight: b=
old;">plasmadesktoptheme.cpp:177</span></div>
<div style=3D"font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quo=
t;Monaco&quot;, monospace; white-space: pre-wrap; clear: both; padding: 4px=
 0; margin: 0;"><div style=3D"padding: 0 8px; margin: 0 4px; background: rg=
ba(151, 234, 151, .6);">        <span class=3D"n">QPalette</span> <span cla=
ss=3D"n">pal</span><span class=3D"p">;</span>
</div><div style=3D"padding: 0 8px; margin: 0 4px; background: rgba(151, 23=
4, 151, .6);">        <span style=3D"color: #aa4000">for</span> <span class=
=3D"p">(</span><span style=3D"color: #aa4000">auto</span> <span style=3D"co=
lor: #a0a000">state</span> <span class=3D"p">:</span> <span class=3D"p">{</=
span> <span class=3D"n">QPalette</span><span style=3D"color: #aa2211">::</s=
pan><span class=3D"n">Active</span><span class=3D"p">,</span> <span class=
=3D"n">QPalette</span><span style=3D"color: #aa2211">::</span><span class=
=3D"n">Inactive</span><span class=3D"p">,</span> <span class=3D"n">QPalette=
</span><span style=3D"color: #aa2211">::</span><span class=3D"n">Disabled</=
span> <span class=3D"p">})</span> <span class=3D"p">{</span>
</div></div></div>
<div style=3D"margin: 8px 0; padding: 0 12px;"><p style=3D"padding: 0; marg=
in: 8px;">I don&#039;t understand this part of the patch in relation to cus=
tom color set support.</p></div></div></div></div></div><br /><div><strong>=
REPOSITORY</strong><div><div>R858 Qt Quick Controls 2: Desktop Style</div><=
/div></div><br /><div><strong>REVISION DETAIL</strong><div><a href=3D"https=
://phabricator.kde.org/D13233">https://phabricator.kde.org/D13233</a></div>=
</div><br /><div><strong>To: </strong>mart, Kirigami, broulik<br /><strong>=
Cc: </strong>davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliez=
hai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>
--6a55675d664e4e2ba6380b019bf62c23--