[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D13210: [Installation Reminder] Watch for service registration and hide
From:       David Edmundson <noreply () phabricator ! kde ! org>
Date:       2018-05-30 9:45:30
Message-ID: 20180530094530.1.3489711B238CC7F0 () phabricator ! kde ! org
[Download RAW message or body]

davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> browserintegrationreminder.cpp:129
> 
> +    m_watcher = new QDBusServiceWatcher(s_dbusServiceName, bus, \
> QDBusServiceWatcher::WatchForRegistration, this); +    connect(m_watcher, \
> &QDBusServiceWatcher::serviceRegistered, this, [this](const QString &service) {

technically best to move this above the check for isServiceRegistered and you avoid \
the slim race possibility.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D13210

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">davidedmundson accepted this revision.<br />davidedmundson \
added inline comments.<br />This revision is now accepted and ready to land. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D13210">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D13210#inline-68614">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">browserintegrationreminder.cpp:129</span></div> <div style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span \
class="n">m_watcher</span> <span style="color: #aa2211">=</span> <span style="color: \
#aa4000">new</span> <span class="n">QDBusServiceWatcher</span><span \
class="p">(</span><span class="n">s_dbusServiceName</span><span class="p">,</span> \
<span class="n">bus</span><span class="p">,</span> <span \
class="n">QDBusServiceWatcher</span><span style="color: #aa2211">::</span><span \
class="n">WatchForRegistration</span><span class="p">,</span> <span style="color: \
#aa4000">this</span><span class="p">);</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span \
class="n">connect</span><span class="p">(</span><span class="n">m_watcher</span><span \
class="p">,</span> <span style="color: #aa2211">&amp;</span><span \
class="n">QDBusServiceWatcher</span><span style="color: #aa2211">::</span><span \
class="n">serviceRegistered</span><span class="p">,</span> <span style="color: \
#aa4000">this</span><span class="p">,</span> <span class="p">[</span><span \
style="color: #aa4000">this</span><span class="p">](</span><span style="color: \
#aa4000">const</span> <span class="n">QString</span> <span style="color: \
#aa2211">&amp;</span><span class="n">service</span><span class="p">)</span> <span \
class="p">{</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">technically best to move this above the check for isServiceRegistered and you \
avoid the slim race possibility.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R856 Plasma Browser \
Integration</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D13210">https://phabricator.kde.org/D13210</a></div></div><br \
/><div><strong>To: </strong>broulik, Plasma, davidedmundson<br /><strong>Cc: \
</strong>plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]