From kde-panel-devel  Wed May 30 09:45:30 2018
From: David Edmundson <noreply () phabricator ! kde ! org>
Date: Wed, 30 May 2018 09:45:30 +0000
To: kde-panel-devel
Subject: D13210: [Installation Reminder] Watch for service registration and hide
Message-Id: <20180530094530.1.3489711B238CC7F0 () phabricator ! kde ! org>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=152767353904470
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--cf13f679d54c43ff8758a516e5d8924c"

--cf13f679d54c43ff8758a516e5d8924c
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="ascii"
Mime-Version: 1.0

davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> browserintegrationreminder.cpp:129
>  
> +    m_watcher = new QDBusServiceWatcher(s_dbusServiceName, bus, QDBusServiceWatcher::WatchForRegistration, this);
> +    connect(m_watcher, &QDBusServiceWatcher::serviceRegistered, this, [this](const QString &service) {

technically best to move this above the check for isServiceRegistered and you avoid the slim race possibility.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D13210

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

--cf13f679d54c43ff8758a516e5d8924c
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html; charset="ascii"
Mime-Version: 1.0

<table><tr><td style=3D"">davidedmundson accepted this revision.<br />david=
edmundson added inline comments.<br />This revision is now accepted and rea=
dy to land.
</td><a style=3D"text-decoration: none; padding: 4px 8px; margin: 0 8px 8px=
; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; back=
ground-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1=
f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href=
=3D"https://phabricator.kde.org/D13210">View Revision</a></tr></table><br /=
><div><strong>INLINE COMMENTS</strong><div><div style=3D"margin: 6px 0 12px=
 0;"><div style=3D"border: 1px solid #C7CCD9; border-radius: 3px;"><div sty=
le=3D"padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style:=
 solid; border-width: 0 0 1px 0; margin: 0;"><div style=3D"color: #74777d; =
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style=3D"float=
: right; text-decoration: none;" href=3D"https://phabricator.kde.org/D13210=
#inline-68614">View Inline</a><span style=3D"color: #4b4d51; font-weight: b=
old;">browserintegrationreminder.cpp:129</span></div>
<div style=3D"font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quo=
t;Monaco&quot;, monospace; white-space: pre-wrap; clear: both; padding: 4px=
 0; margin: 0;"><div style=3D"padding: 0 8px; margin: 0 4px; background: rg=
ba(151, 234, 151, .6);">    <span class=3D"n">m_watcher</span> <span style=
=3D"color: #aa2211">=3D</span> <span style=3D"color: #aa4000">new</span> <s=
pan class=3D"n">QDBusServiceWatcher</span><span class=3D"p">(</span><span c=
lass=3D"n">s_dbusServiceName</span><span class=3D"p">,</span> <span class=
=3D"n">bus</span><span class=3D"p">,</span> <span class=3D"n">QDBusServiceW=
atcher</span><span style=3D"color: #aa2211">::</span><span class=3D"n">Watc=
hForRegistration</span><span class=3D"p">,</span> <span style=3D"color: #aa=
4000">this</span><span class=3D"p">);</span>
</div><div style=3D"padding: 0 8px; margin: 0 4px; background: rgba(151, 23=
4, 151, .6);">    <span class=3D"n">connect</span><span class=3D"p">(</span=
><span class=3D"n">m_watcher</span><span class=3D"p">,</span> <span style=
=3D"color: #aa2211">&amp;</span><span class=3D"n">QDBusServiceWatcher</span=
><span style=3D"color: #aa2211">::</span><span class=3D"n">serviceRegistere=
d</span><span class=3D"p">,</span> <span style=3D"color: #aa4000">this</spa=
n><span class=3D"p">,</span> <span class=3D"p">[</span><span style=3D"color=
: #aa4000">this</span><span class=3D"p">](</span><span style=3D"color: #aa4=
000">const</span> <span class=3D"n">QString</span> <span style=3D"color: #a=
a2211">&amp;</span><span class=3D"n">service</span><span class=3D"p">)</spa=
n> <span class=3D"p">{</span>
</div></div></div>
<div style=3D"margin: 8px 0; padding: 0 12px;"><p style=3D"padding: 0; marg=
in: 8px;">technically best to move this above the check for isServiceRegist=
ered and you avoid the slim race possibility.</p></div></div></div></div></=
div><br /><div><strong>REPOSITORY</strong><div><div>R856 Plasma Browser Int=
egration</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><=
a href=3D"https://phabricator.kde.org/D13210">https://phabricator.kde.org/D=
13210</a></div></div><br /><div><strong>To: </strong>broulik, Plasma, david=
edmundson<br /><strong>Cc: </strong>plasma-devel, ragreen, Pitel, ZrenBot, =
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></d=
iv>
--cf13f679d54c43ff8758a516e5d8924c--