[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D7087: Add "Copy Info" button to the About System KCM
From:       gregormi <noreply () phabricator ! kde ! org>
Date:       2018-05-30 6:40:56
Message-ID: 20180530064056.1.A310C7101699FED2 () phabricator ! kde ! org
[Download RAW message or body]

gregormi marked 5 inline comments as done.
gregormi added inline comments.

INLINE COMMENTS

> gregormi wrote in Module.cpp:246
> Yes, I also had the list idea in an earlier stage of the patch< but without reusing \
> the translated label text. I don't expect the information labels to change often, \
> so I think such a refactoring can be done at a later point in time.

I changed my mind. With all the i18nc comments, I decided it is better to do the \
refactoring now.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D7087

To: gregormi, ngraham, dhaumann
Cc: rkflx, dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, ragreen, \
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">gregormi marked 5 inline comments as done.<br />gregormi \
added inline comments. </td><a style="text-decoration: none; padding: 4px 8px; \
margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: \
3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D7087">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D7087#inline-68570">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">gregormi</span> wrote in <span \
style="color: #4b4d51; font-weight: bold;">Module.cpp:246</span></div> <div \
style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: \
8px;">Yes, I also had the list idea in an earlier stage of the patch&lt; but without \
reusing the translated label text. I don&#039;t expect the information labels to \
change often, so I think such a refactoring can be done at a later point in \
time.</p></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: \
0; margin: 8px;">I changed my mind. With all the i18nc comments, I decided it is \
better to do the refactoring now.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R102 KInfoCenter</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D7087">https://phabricator.kde.org/D7087</a></div></div><br \
/><div><strong>To: </strong>gregormi, ngraham, dhaumann<br /><strong>Cc: \
</strong>rkflx, dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, \
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, \
mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]