[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D7087: Add "Copy Info" button to the About System KCM
From: gregormi <noreply () phabricator ! kde ! org>
Date: 2018-05-30 6:39:58
Message-ID: 20180530063958.1.2D04B9EF0030FD84 () phabricator ! kde ! org
[Download RAW message or body]
gregormi updated this revision to Diff 35158.
gregormi marked 2 inline comments as done.
gregormi added a comment.
- Translate the Distro string
- Rename button to 'Copy to Clipboard' for more clarity; and consistency with other \
applications
- Use a QList of QPairs to collect labels and then use a loop
REPOSITORY
R102 KInfoCenter
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7087?vs=34111&id=35158
BRANCH
arcpatch-D7087_1
REVISION DETAIL
https://phabricator.kde.org/D7087
AFFECTED FILES
Modules/about-distro/src/Module.cpp
Modules/about-distro/src/Module.h
Modules/about-distro/src/Module.ui
To: gregormi, ngraham, dhaumann
Cc: rkflx, dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, ragreen, \
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart
[Attachment #3 (unknown)]
<table><tr><td style="">gregormi updated this revision to Diff 35158.<br />gregormi \
marked 2 inline comments as done.<br />gregormi added a comment. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D7087">View \
Revision</a></tr></table><br /><div><div><ul class="remarkup-list"> <li \
class="remarkup-list-item">Translate the Distro string</li> <li \
class="remarkup-list-item">Rename button to 'Copy to Clipboard' for more \
clarity; and consistency with other applications</li> <li \
class="remarkup-list-item">Use a QList of QPairs to collect labels and then use a \
loop</li> </ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R102 \
KInfoCenter</div></div></div><br /><div><strong>CHANGES SINCE LAST \
UPDATE</strong><div><a \
href="https://phabricator.kde.org/D7087?vs=34111&id=35158">https://phabricator.kde.org/D7087?vs=34111&id=35158</a></div></div><br \
/><div><strong>BRANCH</strong><div><div>arcpatch-D7087_1</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D7087">https://phabricator.kde.org/D7087</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>Modules/about-distro/src/Module.cpp<br /> \
Modules/about-distro/src/Module.h<br /> \
Modules/about-distro/src/Module.ui</div></div></div><br /><div><strong>To: \
</strong>gregormi, ngraham, dhaumann<br /><strong>Cc: </strong>rkflx, dhaumann, \
ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, ragreen, Pitel, ZrenBot, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic