[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog
From:       Chris Holland <noreply () phabricator ! kde ! org>
Date:       2018-04-16 12:24:19
Message-ID: 20180416122419.1.FA604A76D7380856 () phabricator ! kde ! org
[Download RAW message or body]

Zren added inline comments.

INLINE COMMENTS

> davidedmundson wrote in wallpaperplugin.cpp:26
> You don't need to do this.
> 
> QPointer has a custom -> operator
> 
> So m_newStuffDialog->setTitle works just fine.
> 
> Same for in newStuffFinished

I copy pasted from `image.cpp` ... which apparently hasn't been touched in 4 years \
since the import from kde-workspace.

- https://github.com/KDE/plasma-workspace/blame/master/wallpapers/image/image.cpp#L600


Will that function need updating too?

REPOSITORY
  R131 Plasma Wallpapers

REVISION DETAIL
  https://phabricator.kde.org/D12040

To: Zren, #plasma
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">Zren added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D12040">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D12040#inline-61792">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">davidedmundson</span> wrote in <span \
style="color: #4b4d51; font-weight: bold;">wallpaperplugin.cpp:26</span></div> <div \
style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: \
8px;">You don&#039;t need to do this.</p>

<p style="padding: 0; margin: 8px;">QPointer has a custom -&gt; operator</p>

<p style="padding: 0; margin: 8px;">So m_newStuffDialog-&gt;setTitle works just \
fine.</p>

<p style="padding: 0; margin: 8px;">Same for in newStuffFinished</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I \
copy pasted from <tt style="background: #ebebeb; font-size: 13px;">image.cpp</tt> ... \
which apparently hasn&#039;t been touched in 4 years since the import from \
kde-workspace.</p>

<ul class="remarkup-list">
<li class="remarkup-list-item"><a \
href="https://github.com/KDE/plasma-workspace/blame/master/wallpapers/image/image.cpp#L600" \
class="remarkup-link" target="_blank" \
rel="noreferrer">https://github.com/KDE/plasma-workspace/blame/master/wallpapers/image/image.cpp#L600</a></li>
 </ul>

<p style="padding: 0; margin: 8px;">Will that function need updating \
too?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R131 Plasma \
Wallpapers</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D12040">https://phabricator.kde.org/D12040</a></div></div><br \
/><div><strong>To: </strong>Zren, Plasma<br /><strong>Cc: </strong>davidedmundson, \
plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]