[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog
From:       David Edmundson <noreply () phabricator ! kde ! org>
Date:       2018-04-16 7:36:04
Message-ID: 20180416073604.1.E88884CED0674268 () phabricator ! kde ! org
[Download RAW message or body]

davidedmundson added a comment.


  cool, seems mostly fine. One minor style comment

INLINE COMMENTS

> wallpaperplugin.cpp:26
> +        m_newStuffDialog = new KNS3::DownloadDialog( \
> QString::fromLatin1("wallpaperplugin.knsrc") ); +        KNS3::DownloadDialog \
> *strong = m_newStuffDialog.data(); +        strong->setTitle(i18n("Download \
> Wallpaper Plugins"));

You don't need to do this.

QPointer has a custom -> operator

So m_newStuffDialog->setTitle works just fine.

Same for in newStuffFinished

REPOSITORY
  R131 Plasma Wallpapers

REVISION DETAIL
  https://phabricator.kde.org/D12040

To: Zren, #plasma
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">davidedmundson added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D12040">View Revision</a></tr></table><br \
/><div><div><p>cool, seems mostly fine. One minor style comment</p></div></div><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D12040#inline-61792">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">wallpaperplugin.cpp:26</span></div> <div \
style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        \
<span class="n">m_newStuffDialog</span> <span style="color: #aa2211">=</span> <span \
style="color: #aa4000">new</span> <span class="n">KNS3</span><span style="color: \
#aa2211">::</span><span class="n">DownloadDialog</span><span class="p">(</span> <span \
class="n">QString</span><span style="color: #aa2211">::</span><span \
class="n">fromLatin1</span><span class="p">(</span><span style="color: \
#766510">&quot;wallpaperplugin.knsrc&quot;</span><span class="p">)</span> <span \
class="p">);</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);">        <span class="n">KNS3</span><span style="color: \
#aa2211">::</span><span class="n">DownloadDialog</span> <span style="color: \
#aa2211">*</span><span class="n">strong</span> <span style="color: #aa2211">=</span> \
<span class="n">m_newStuffDialog</span><span class="p">.</span><span \
class="n">data</span><span class="p">();</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span \
class="n">strong</span><span style="color: #aa2211">-&gt;</span><span \
class="n">setTitle</span><span class="p">(</span><span class="n">i18n</span><span \
class="p">(</span><span style="color: #766510">&quot;Download Wallpaper \
Plugins&quot;</span><span class="p">));</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You \
don&#039;t need to do this.</p>

<p style="padding: 0; margin: 8px;">QPointer has a custom -&gt; operator</p>

<p style="padding: 0; margin: 8px;">So m_newStuffDialog-&gt;setTitle works just \
fine.</p>

<p style="padding: 0; margin: 8px;">Same for in \
newStuffFinished</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R131 Plasma \
Wallpapers</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D12040">https://phabricator.kde.org/D12040</a></div></div><br \
/><div><strong>To: </strong>Zren, Plasma<br /><strong>Cc: </strong>davidedmundson, \
plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]