[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D11021: [Media controller] Add simple volume control
From: Radek_HuĊĦek <noreply () phabricator ! kde ! org>
Date: 2018-03-30 19:06:59
Message-ID: 20180330190659.1.88700B9B2D289A7B () phabricator ! kde ! org
[Download RAW message or body]
Pitel updated this revision to Diff 30963.
Pitel added a comment.
Convert `changeVolume` helper into a Job... Right now it does not check \
wheter the DBus call is successful - I tried to wire it in but ended with \
segfault. I will investigate it further. Except that I hope it is ok.
(I also started thinking how to change the job system into something \
easier to work with. Were there any attempts in this direction?)
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D11021?vs=28729&id=30963
BRANCH
mediacontroller
REVISION DETAIL
https://phabricator.kde.org/D11021
AFFECTED FILES
applets/mediacontroller/contents/ui/main.qml
dataengines/mpris2/mpris2.operations
dataengines/mpris2/multiplexedservice.cpp
dataengines/mpris2/playeractionjob.cpp
dataengines/mpris2/playercontrol.cpp
dataengines/mpris2/playercontrol.h
To: Pitel, #plasma, broulik
Cc: broulik, nicolasfella, plasma-devel, ragreen, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
[Attachment #3 (unknown)]
<table><tr><td style="">Pitel updated this revision to Diff 30963.<br \
/>Pitel added a comment. </td><a style="text-decoration: none; padding: 4px \
8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; \
border-radius: 3px; background-color: #F7F7F9; background-image: \
linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px \
solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D11021">View \
Revision</a></tr></table><br /><div><div><div class="remarkup-code-block" \
style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: \
11px/15px "Menlo", "Consolas", "Monaco", \
monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, \
0.08);">Convert `changeVolume` helper into a Job... Right now it does not \
check wheter the DBus call is successful - I tried to wire it in but ended \
with segfault. I will investigate it further. Except that I hope it is ok.
(I also started thinking how to change the job system into something easier \
to work with. Were there any attempts in this \
direction?)</pre></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>CHANGES SINCE LAST \
UPDATE</strong><div><a \
href="https://phabricator.kde.org/D11021?vs=28729&id=30963">https://phabricator.kde.org/D11021?vs=28729&id=30963</a></div></div><br \
/><div><strong>BRANCH</strong><div><div>mediacontroller</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D11021">https://phabricator.kde.org/D11021</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>applets/mediacontroller/contents/ui/main.qml<br /> \
dataengines/mpris2/mpris2.operations<br /> \
dataengines/mpris2/multiplexedservice.cpp<br /> \
dataengines/mpris2/playeractionjob.cpp<br /> \
dataengines/mpris2/playercontrol.cpp<br /> \
dataengines/mpris2/playercontrol.h</div></div></div><br /><div><strong>To: \
</strong>Pitel, Plasma, broulik<br /><strong>Cc: </strong>broulik, \
nicolasfella, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic