From kde-panel-devel  Fri Mar 30 19:06:59 2018
From: =?utf-8?q?Radek_Hu=C5=A1ek?= <noreply () phabricator ! kde ! org>
Date: Fri, 30 Mar 2018 19:06:59 +0000
To: kde-panel-devel
Subject: D11021: [Media controller] Add simple volume control
Message-Id: <20180330190659.1.88700B9B2D289A7B () phabricator ! kde ! org>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=152243683317820
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--7bd495aec2f5443886a5ee523edf7766"

--7bd495aec2f5443886a5ee523edf7766
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="ascii"
Mime-Version: 1.0

Pitel updated this revision to Diff 30963.
Pitel added a comment.


    Convert `changeVolume` helper into a Job... Right now it does not check wheter the DBus call is successful - I tried to wire it in but ended with segfault. I will investigate it further. Except that I hope it is ok.
    
    (I also started thinking how to change the job system into something easier to work with. Were there any attempts in this direction?)

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11021?vs=28729&id=30963

BRANCH
  mediacontroller

REVISION DETAIL
  https://phabricator.kde.org/D11021

AFFECTED FILES
  applets/mediacontroller/contents/ui/main.qml
  dataengines/mpris2/mpris2.operations
  dataengines/mpris2/multiplexedservice.cpp
  dataengines/mpris2/playeractionjob.cpp
  dataengines/mpris2/playercontrol.cpp
  dataengines/mpris2/playercontrol.h

To: Pitel, #plasma, broulik
Cc: broulik, nicolasfella, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

--7bd495aec2f5443886a5ee523edf7766
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html; charset="ascii"
Mime-Version: 1.0

<table><tr><td style=3D"">Pitel updated this revision to Diff 30963.<br />P=
itel added a comment.
</td><a style=3D"text-decoration: none; padding: 4px 8px; margin: 0 8px 8px=
; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; back=
ground-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1=
f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href=
=3D"https://phabricator.kde.org/D11021">View Revision</a></tr></table><br /=
><div><div><div class=3D"remarkup-code-block" style=3D"margin: 12px 0;" dat=
a-code-lang=3D"text" data-sigil=3D"remarkup-code-block"><pre class=3D"remar=
kup-code" style=3D"font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;,=
 &quot;Monaco&quot;, monospace; padding: 12px; margin: 0; background: rgba(=
71, 87, 120, 0.08);">Convert `changeVolume` helper into a Job... Right now =
it does not check wheter the DBus call is successful - I tried to wire it i=
n but ended with segfault. I will investigate it further. Except that I hop=
e it is ok.

(I also started thinking how to change the job system into something easier=
 to work with. Were there any attempts in this direction?)</pre></div></div=
></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspac=
e</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><di=
v><a href=3D"https://phabricator.kde.org/D11021?vs=3D28729&amp;id=3D30963">=
https://phabricator.kde.org/D11021?vs=3D28729&amp;id=3D30963</a></div></div=
><br /><div><strong>BRANCH</strong><div><div>mediacontroller</div></div></d=
iv><br /><div><strong>REVISION DETAIL</strong><div><a href=3D"https://phabr=
icator.kde.org/D11021">https://phabricator.kde.org/D11021</a></div></div><b=
r /><div><strong>AFFECTED FILES</strong><div><div>applets/mediacontroller/c=
ontents/ui/main.qml<br />
dataengines/mpris2/mpris2.operations<br />
dataengines/mpris2/multiplexedservice.cpp<br />
dataengines/mpris2/playeractionjob.cpp<br />
dataengines/mpris2/playercontrol.cpp<br />
dataengines/mpris2/playercontrol.h</div></div></div><br /><div><strong>To: =
</strong>Pitel, Plasma, broulik<br /><strong>Cc: </strong>broulik, nicolasf=
ella, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterbe=
rg, abetts, sebas, apol, mart<br /></div>
--7bd495aec2f5443886a5ee523edf7766--