[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D10297: Add new "Tools" button above System Monitor's process list
From:       Henrik Fehlauer <noreply () phabricator ! kde ! org>
Date:       2018-03-21 22:27:27
Message-ID: 20180321222727.1.B36177A2BF5A3EAD () phabricator ! kde ! org
[Download RAW message or body]

rkflx added inline comments.

INLINE COMMENTS

> rkflx wrote in ksysguardprocesslist.cpp:412
> Could you do an exact match on the filename, i.e. only the last part of the full \
> path? There might be situations where "System Monitor" is developed or installed in \
> a directory containing this string by chance.

Recently I learned comparing with `qApp->desktopFileName()` might be even better than \
looking at the path of the executable…

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D10297

To: gregormi, #plasma, colomar, kossebau, broulik, mart, hein
Cc: apol, anthonyfieroni, andreaska, rkflx, ngraham, plasma-devel, ZrenBot, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart


[Attachment #3 (unknown)]

<table><tr><td style="">rkflx added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D10297">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D10297#inline-56762">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">rkflx</span> wrote in <span style="color: \
#4b4d51; font-weight: bold;">ksysguardprocesslist.cpp:412</span></div> <div \
style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: \
8px;">Could you do an exact match on the filename, i.e. only the last part of the \
full path? There might be situations where &quot;System Monitor&quot; is developed or \
installed in a directory containing this string by chance.</p></div></div> <div \
style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Recently \
I learned comparing with <tt style="background: #ebebeb; font-size: \
13px;">qApp-&gt;desktopFileName()</tt> might be even better than looking at the path \
of the executable…</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R111 KSysguard \
Library</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D10297">https://phabricator.kde.org/D10297</a></div></div><br \
/><div><strong>To: </strong>gregormi, Plasma, colomar, kossebau, broulik, mart, \
hein<br /><strong>Cc: </strong>apol, anthonyfieroni, andreaska, rkflx, ngraham, \
plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, \
mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]