[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D10297: Add new "Tools" button above System Monitor's process list
From: Henrik Fehlauer <noreply () phabricator ! kde ! org>
Date: 2018-03-20 12:26:46
Message-ID: 20180320122646.1.B3F18613E44265C0 () phabricator ! kde ! org
[Download RAW message or body]
rkflx added a comment.
The new access button is really great, but Kill a window still looks a bit \
unfinished to me:
- The text should use title case: "Kill a Window"
- The shortcut does not get localized. (In the global shortcuts KCM, it is \
localized correctly for me.)
- The parentheses look a bit ugly, in normal menus the shortcuts are simply aligned \
to the right (not sure how that's done, though).
INLINE COMMENTS
> CMakeLists.txt:37
>
> -find_package(KF5 REQUIRED COMPONENTS CoreAddons Config I18n WindowSystem \
> Completion Auth WidgetsAddons IconThemes ConfigWidgets Service) +find_package(KF5 \
> REQUIRED COMPONENTS CoreAddons Config I18n WindowSystem Completion Auth \
> WidgetsAddons IconThemes ConfigWidgets Service Plasma GlobalAccel KIO) \
> find_package(KF5 OPTIONAL_COMPONENTS Plasma)
Is `Plasma` needed here? If so, I think this needs more discussion or should be made \
optional.
KSysGuard can also be used in other desktop environments and perhaps other apps \
consume this library too (KDevelop?), all of them might not want to bring in a huge \
dependency on Plasma.
> ProcessWidgetUI.ui:71
> </property>
> - <property name="clearButtonEnabled" stdset="0">
> <bool>true</bool>
Unrelated change?
(Comment applies also to a bunch of other places with the same change.)
> ksysguardprocesslist.cpp:386
>
> + d->mUi->btnKillProcess->setEnabled(false);
> d->mUi->btnKillProcess->setIcon(QIcon::fromTheme(QStringLiteral("process-stop")));
Do you really need this? Maybe it's enough if you don't change this property to \
`true` in `processui/ProcessWidgetUI.ui:31`.
> ksysguardprocesslist.cpp:390
> +
> + auto d1 = d;
> + auto addByDesktopName = [this, d1](const QString& desktopName)
What does `d1` mean? Is it necessary to duplicate the d-pointer?
As far as I can see, you are already capturing `this` in the lambda, so you won't \
need to capture `(this->)d`.
> ksysguardprocesslist.cpp:395
> + auto kService = KService::serviceByDesktopName(desktopName);
> + if (kService != nullptr) {
> + auto action = new QAction(QIcon::fromTheme(kService->icon()),
Drop `!= nullptr`.
> ksysguardprocesslist.cpp:412
> + // And in this case we do not add the KSysGuard item to the menu.
> + if (!QCoreApplication::applicationFilePath().contains(QStringLiteral("ksysguard"))) \
> { + addByDesktopName(QStringLiteral("org.kde.ksysguard"));
Could you do an exact match on the filename, i.e. only the last part of the full \
path? There might be situations where "System Monitor" is developed or installed in a \
directory containing this string by chance.
> ksysguardprocesslist.cpp:419-420
> + addByDesktopName(QStringLiteral("org.kde.filelight"));
> + addByDesktopName(QStringLiteral("sweeper"));
> + addByDesktopName(QStringLiteral("kmag"));
> + addByDesktopName(QStringLiteral("htop"));
Sweeper and KMag do not show up for me, even though I have both of them installed. Is \
your naming correct?
(Sidenote: This smells like it should be handled by your KMoreTools, although that \
would probably require some changes there first… :)
> ksysguardprocesslist.cpp:423
> +
> + {
> + auto action = new QAction(i18n("Run Command"), this);
This looks a bit odd. I would organize this with linebreaks alone, no need for \
separate code blocks.
> ksysguardprocesslist.cpp:424
> + {
> + auto action = new QAction(i18n("Run Command"), this);
> + action->setIcon(QIcon::fromTheme(QStringLiteral("system-run")));
Please give your variable a more descriptive name.
> gregormi wrote in ksysguardprocesslist.cpp:360
> does this comment still apply?
Yes, it still shows up as a whitespace change on Phabricator.
REPOSITORY
R111 KSysguard Library
REVISION DETAIL
https://phabricator.kde.org/D10297
To: gregormi, #plasma, colomar, kossebau, broulik, mart, hein
Cc: apol, anthonyfieroni, andreaska, rkflx, ngraham, plasma-devel, ZrenBot, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
[Attachment #3 (unknown)]
<table><tr><td style="">rkflx added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D10297">View Revision</a></tr></table><br \
/><div><div><p>The new access button is really great, but <span><span \
class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span \
class="phui-tag-core ">Kill a window</span></span></span> still looks a bit \
unfinished to me:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">The text should use title case: "Kill a \
Window"</li> <li class="remarkup-list-item">The shortcut does not get localized. \
(In the global shortcuts KCM, it is localized correctly for me.)</li> <li \
class="remarkup-list-item">The parentheses look a bit ugly, in normal menus the \
shortcuts are simply aligned to the right (not sure how that's done, \
though).</li> </ul></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D10297#inline-56763">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">CMakeLists.txt:37</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(251, 175, 175, .7);">find_package(KF5 REQUIRED COMPONENTS CoreAddons \
Config I18n WindowSystem Completion Auth WidgetsAddons IconThemes ConfigWidgets \
Service) </div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, \
151, .6);">find_package(KF5 REQUIRED COMPONENTS CoreAddons Config I18n WindowSystem \
Completion Auth WidgetsAddons IconThemes ConfigWidgets Service<span class="bright"> \
Plasma GlobalAccel KIO</span>) </div><div style="padding: 0 8px; margin: 0 4px; \
">find_package(KF5 OPTIONAL_COMPONENTS Plasma) </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Is \
<tt style="background: #ebebeb; font-size: 13px;">Plasma</tt> needed here? If so, I \
think this needs more discussion or should be made optional.</p>
<p style="padding: 0; margin: 8px;">KSysGuard can also be used in other desktop \
environments and perhaps other apps consume this library too (KDevelop?), all of them \
might not want to bring in a huge dependency on Plasma.</p></div></div><br /><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D10297#inline-56758">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">ProcessWidgetUI.ui:71</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; "> </property> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> \
<property name="clearButtonEnabled"<span class="bright"> \
stdset="0"</span>> </div><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);"> <property \
name="clearButtonEnabled"> </div><div style="padding: 0 8px; margin: 0 \
4px; "> <bool>true</bool> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Unrelated change?</p>
<p style="padding: 0; margin: 8px;">(Comment applies also to a bunch of other places \
with the same change.)</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" \
href="https://phabricator.kde.org/D10297#inline-56759">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">ksysguardprocesslist.cpp:386</span></div> \
<div style="font: 11px/15px "Menlo", "Consolas", \
"Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; \
margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, \
151, .6);"> <span class="n">d</span><span style="color: #aa2211">-></span><span \
class="n">mUi</span><span style="color: #aa2211">-></span><span \
class="n">btnKillProcess</span><span style="color: #aa2211">-></span><span \
class="n">setEnabled</span><span class="p">(</span><span style="color: \
#304a96">false</span><span class="p">);</span> </div><div style="padding: 0 8px; \
margin: 0 4px; "> <span class="n">d</span><span style="color: \
#aa2211">-></span><span class="n">mUi</span><span style="color: \
#aa2211">-></span><span class="n">btnKillProcess</span><span style="color: \
#aa2211">-></span><span class="n">setIcon</span><span class="p">(</span><span \
class="n">QIcon</span><span style="color: #aa2211">::</span><span \
class="n">fromTheme</span><span class="p">(</span><span \
class="n">QStringLiteral</span><span class="p">(</span><span style="color: \
#766510">"process-stop"</span><span class="p">)));</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">Do you really need this? Maybe it's enough if you don't \
change this property to <tt style="background: #ebebeb; font-size: 13px;">true</tt> \
in <tt style="background: #ebebeb; font-size: \
13px;">processui/ProcessWidgetUI.ui:31</tt>.</p></div></div><br /><div style="border: \
1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D10297#inline-56761">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">ksysguardprocesslist.cpp:390</span></div> \
<div style="font: 11px/15px "Menlo", "Consolas", \
"Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; \
margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, \
151, .6);"> <span style="color: #aa4000">auto</span> <span class="n">d1</span> \
<span style="color: #aa2211">=</span> <span class="n">d</span><span \
class="p">;</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span style="color: #aa4000">auto</span> <span \
class="n">addByDesktopName</span> <span style="color: #aa2211">=</span> <span \
class="p">[</span><span style="color: #aa4000">this</span><span class="p">,</span> \
<span class="n">d1</span><span class="p">](</span><span style="color: \
#aa4000">const</span> <span class="n">QString</span><span style="color: \
#aa2211">&</span> <span class="n">desktopName</span><span class="p">)</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">What does <tt style="background: #ebebeb; font-size: 13px;">d1</tt> \
mean? Is it necessary to duplicate the d-pointer?</p>
<p style="padding: 0; margin: 8px;">As far as I can see, you are already capturing \
<tt style="background: #ebebeb; font-size: 13px;">this</tt> in the lambda, so you \
won't need to capture <tt style="background: #ebebeb; font-size: \
13px;">(this->)d</tt>.</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" \
href="https://phabricator.kde.org/D10297#inline-56764">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">ksysguardprocesslist.cpp:395</span></div> \
<div style="font: 11px/15px "Menlo", "Consolas", \
"Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; \
margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, \
151, .6);"> <span style="color: #aa4000">auto</span> <span \
class="n">kService</span> <span style="color: #aa2211">=</span> <span \
class="n">KService</span><span style="color: #aa2211">::</span><span \
class="n">serviceByDesktopName</span><span class="p">(</span><span \
class="n">desktopName</span><span class="p">);</span> </div><div style="padding: 0 \
8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: \
#aa4000">if</span> <span class="p">(</span><span class="n">kService</span> <span \
style="color: #aa2211">!=</span> <span style="color: #aa4000">nullptr</span><span \
class="p">)</span> <span class="p">{</span> </div><div style="padding: 0 8px; margin: \
0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: \
#aa4000">auto</span> <span class="n">action</span> <span style="color: \
#aa2211">=</span> <span style="color: #aa4000">new</span> <span \
class="n">QAction</span><span class="p">(</span><span class="n">QIcon</span><span \
style="color: #aa2211">::</span><span class="n">fromTheme</span><span \
class="p">(</span><span class="n">kService</span><span style="color: \
#aa2211">-></span><span class="n">icon</span><span class="p">()),</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">Drop <tt style="background: #ebebeb; font-size: 13px;">!= \
nullptr</tt>.</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" \
href="https://phabricator.kde.org/D10297#inline-56762">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">ksysguardprocesslist.cpp:412</span></div> \
<div style="font: 11px/15px "Menlo", "Consolas", \
"Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; \
margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, \
151, .6);"> <span style="color: #74777d">// And in this case we do not add the \
KSysGuard item to the menu.</span> </div><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> \
<span class="p">(</span><span style="color: #aa2211">!</span><span \
class="n">QCoreApplication</span><span style="color: #aa2211">::</span><span \
class="n">applicationFilePath</span><span class="p">().</span><span \
class="n">contains</span><span class="p">(</span><span \
class="n">QStringLiteral</span><span class="p">(</span><span style="color: \
#766510">"ksysguard"</span><span class="p">)))</span> <span \
class="p">{</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span class="n">addByDesktopName</span><span \
class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span \
style="color: #766510">"org.kde.ksysguard"</span><span class="p">));</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">Could you do an exact match on the filename, i.e. only the last part of \
the full path? There might be situations where "System Monitor" is \
developed or installed in a directory containing this string by \
chance.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D10297#inline-56769">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">ksysguardprocesslist.cpp:419-420</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
class="n">addByDesktopName</span><span class="p">(</span><span \
class="n">QStringLiteral</span><span class="p">(</span><span style="color: \
#766510">"org.kde.filelight"</span><span class="p">));</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
class="n">addByDesktopName</span><span class="p">(</span><span \
class="n">QStringLiteral</span><span class="p">(</span><span style="color: \
#766510">"sweeper"</span><span class="p">));</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
class="n">addByDesktopName</span><span class="p">(</span><span \
class="n">QStringLiteral</span><span class="p">(</span><span style="color: \
#766510">"kmag"</span><span class="p">));</span> </div><div style="padding: \
0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
class="n">addByDesktopName</span><span class="p">(</span><span \
class="n">QStringLiteral</span><span class="p">(</span><span style="color: \
#766510">"htop"</span><span class="p">));</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Sweeper and KMag do not show up for me, even though I have both of them \
installed. Is your naming correct?</p>
<p style="padding: 0; margin: 8px;">(Sidenote: This smells like it should be handled \
by your KMoreTools, although that would probably require some changes there first… \
:)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D10297#inline-56765">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">ksysguardprocesslist.cpp:423</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">{</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"> <span style="color: #aa4000">auto</span> <span class="n">action</span> \
<span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span \
class="n">QAction</span><span class="p">(</span><span class="n">i18n</span><span \
class="p">(</span><span style="color: #766510">"Run Command"</span><span \
class="p">),</span> <span style="color: #aa4000">this</span><span class="p">);</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">This looks a bit odd. I would organize this with linebreaks alone, no \
need for separate code blocks.</p></div></div><br /><div style="border: 1px solid \
#C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D10297#inline-56766">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">ksysguardprocesslist.cpp:424</span></div> \
<div style="font: 11px/15px "Menlo", "Consolas", \
"Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; \
margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, \
151, .6);"> <span class="p">{</span> </div><div style="padding: 0 8px; margin: 0 \
4px; background: rgba(151, 234, 151, .6);"> <span style="color: \
#aa4000">auto</span> <span class="n">action</span> <span style="color: \
#aa2211">=</span> <span style="color: #aa4000">new</span> <span \
class="n">QAction</span><span class="p">(</span><span class="n">i18n</span><span \
class="p">(</span><span style="color: #766510">"Run Command"</span><span \
class="p">),</span> <span style="color: #aa4000">this</span><span class="p">);</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"> <span class="n">action</span><span style="color: \
#aa2211">-></span><span class="n">setIcon</span><span class="p">(</span><span \
class="n">QIcon</span><span style="color: #aa2211">::</span><span \
class="n">fromTheme</span><span class="p">(</span><span \
class="n">QStringLiteral</span><span class="p">(</span><span style="color: \
#766510">"system-run"</span><span class="p">)));</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Please give your variable a more descriptive name.</p></div></div><br /><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D10297#inline-49832">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">gregormi</span> wrote in <span \
style="color: #4b4d51; font-weight: bold;">ksysguardprocesslist.cpp:360</span></div> \
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; \
margin: 8px;">does this comment still apply?</p></div></div> <div style="margin: 8px \
0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Yes, it still shows up as a \
whitespace change on Phabricator.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R111 KSysguard \
Library</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D10297">https://phabricator.kde.org/D10297</a></div></div><br \
/><div><strong>To: </strong>gregormi, Plasma, colomar, kossebau, broulik, mart, \
hein<br /><strong>Cc: </strong>apol, anthonyfieroni, andreaska, rkflx, ngraham, \
plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, \
mart<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic