[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D10901: Add "move to device" functionality to hamburger menu
From:       Christian <noreply () phabricator ! kde ! org>
Date:       2018-02-27 19:57:11
Message-ID: 20180227195711.1.0578AD2C7F44461C () phabricator ! kde ! org
[Download RAW message or body]

Fuchs added a comment.


  In D10901#215244 <https://phabricator.kde.org/D10901#215244>, @drosca wrote:
  
  >
  
  
  
  
  > Can you merge the code into one block?
  
  Technically yes, but due to some edge cases it will make it hacky and difficult to \
read.  
  Example: you can have a second device connected which is only an output (bluetooth \
speakers), but no input. Therefore before adding the menu entries you have to check \
whether there are currently available output or input types, depending on the \
situation.   So there will be a lot of conditionals, not just for setting labels, but \
for actual logic.  
  I'll see which is the least bad attempt at that and upload a second diff, but I am \
not conviced it will be nicer.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D10901

To: Fuchs, broulik, drosca
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, \
sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">Fuchs added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D10901" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid \
#8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a \
href="https://phabricator.kde.org/D10901#215244" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">D10901#215244</a>, <a \
href="https://phabricator.kde.org/p/drosca/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@drosca</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"></div>
</blockquote>



<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: \
italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Can \
you merge the code into one block?</p></blockquote>

<p>Technically yes, but due to some edge cases it will make it hacky and difficult to \
read.</p>

<p>Example: you can have a second device connected which is only an output (bluetooth \
speakers), but no input. Therefore before adding the menu entries you have to check \
whether there are currently available output or input types, depending on the \
situation. <br /> So there will be a lot of conditionals, not just for setting \
labels, but for actual logic.</p>

<p>I&#039;ll see which is the least bad attempt at that and upload a second diff, but \
I am not conviced it will be nicer.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R115 Plasma Audio Volume \
Applet</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D10901" \
rel="noreferrer">https://phabricator.kde.org/D10901</a></div></div><br \
/><div><strong>To: </strong>Fuchs, broulik, drosca<br /><strong>Cc: </strong>ngraham, \
plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, \
mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]