[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D10901: Add "move to device" functionality to hamburger menu
From: David Rosca <noreply () phabricator ! kde ! org>
Date: 2018-02-27 19:48:13
Message-ID: 20180227194813.1.8416D6DFCD3C9234 () phabricator ! kde ! org
[Download RAW message or body]
drosca requested changes to this revision.
drosca added a comment.
This revision now requires changes to proceed.
I'm not sure on the wording "Output on" "Record from", I would prefer simple "Move \
to" or "Move to device", but I am not native speaker so I leave others to decide.
Can you merge the code into one block? As it is now, the code is duplicated and the \
only difference is that first block uses `sourceView` and second `sinkView`, but only \
one of those two blocks can ever be executed (can't be both sink-input and \
source-output).
INLINE COMMENTS
> ListItemBase.qml:338
> + // remove the second condition in the if to always show it.
> + if (type == "sink-input" && sinkView.model.count > 1) {
> + contextMenu.addMenuItem(newSeperator());
`sinkView.model.count > 1` -> `sinkView.count`
REPOSITORY
R115 Plasma Audio Volume Applet
REVISION DETAIL
https://phabricator.kde.org/D10901
To: Fuchs, broulik, drosca
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, \
apol, mart
[Attachment #3 (unknown)]
<table><tr><td style="">drosca requested changes to this revision.<br />drosca added \
a comment.<br />This revision now requires changes to proceed. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10901" \
rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>I'm not sure \
on the wording "Output on" "Record from", I would prefer simple \
"Move to" or "Move to device", but I am not native speaker so I \
leave others to decide.</p>
<p>Can you merge the code into one block? As it is now, the code is duplicated and \
the only difference is that first block uses <tt style="background: #ebebeb; \
font-size: 13px;">sourceView</tt> and second <tt style="background: #ebebeb; \
font-size: 13px;">sinkView</tt>, but only one of those two blocks can ever be \
executed (can't be both sink-input and source-output).</p></div></div><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D10901#inline-52319" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">ListItemBase.qml:338</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: \
#74777d">// remove the second condition in the if to always show it.</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"> <span style="color: #aa4000">if</span> <span \
class="p">(</span><span style="color: #004012">type</span> <span style="color: \
#aa2211">==</span> <span style="color: #766510">"sink-input"</span> <span \
style="color: #aa2211">&&</span> <span style="color: \
#004012">sinkView</span><span class="p">.</span><span style="color: \
#004012">model</span><span class="p">.</span><span style="color: \
#004012">count</span> <span style="color: #aa2211">></span> <span style="color: \
#601200">1</span><span class="p">)</span> <span class="p">{</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> \
<span style="color: #004012">contextMenu</span><span class="p">.</span><span \
style="color: #004012">addMenuItem</span><span class="p">(</span><span style="color: \
#004012">newSeperator</span><span class="p">());</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt \
style="background: #ebebeb; font-size: 13px;">sinkView.model.count > 1</tt> -> \
<tt style="background: #ebebeb; font-size: \
13px;">sinkView.count</tt></p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R115 Plasma Audio Volume \
Applet</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D10901" \
rel="noreferrer">https://phabricator.kde.org/D10901</a></div></div><br \
/><div><strong>To: </strong>Fuchs, broulik, drosca<br /><strong>Cc: \
</strong>plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, \
sebas, apol, mart<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic