[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D10197: Fix krunner's alt+f2 on wayland
From:       Martin_Flöser <noreply () phabricator ! kde ! org>
Date:       2018-02-06 16:29:41
Message-ID: 20180206162941.1.F9B9D0B22B7405E1 () phabricator ! kde ! org
[Download RAW message or body]

graesslin added a comment.


  I really think this needs to be reverted. Krunner must be a dock, it must be set to \
windows go below and it must take focus. This is all functionality not provided by \
Plasma::Dialog. Just removing the code doesn't work unfortunately.  
  I have a hard time understanding what the actual problem was. For me KRunner was \
always working. The change says it's about workarounds for X11, but that doesn't \
match the change as everything what's red is Wayland only. Can someone elaborate on \
what the actual problem was which this change was trying to address.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10197

To: apol, #plasma, davidedmundson
Cc: graesslin, broulik, ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">graesslin added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D10197" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>I really think this needs to be reverted. \
Krunner must be a dock, it must be set to windows go below and it must take focus. \
This is all functionality not provided by Plasma::Dialog. Just removing the code \
doesn&#039;t work unfortunately.</p>

<p>I have a hard time understanding what the actual problem was. For me KRunner was \
always working. The change says it&#039;s about workarounds for X11, but that \
doesn&#039;t match the change as everything what&#039;s red is Wayland only. Can \
someone elaborate on what the actual problem was which this change was trying to \
address.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D10197" \
rel="noreferrer">https://phabricator.kde.org/D10197</a></div></div><br \
/><div><strong>To: </strong>apol, Plasma, davidedmundson<br /><strong>Cc: \
</strong>graesslin, broulik, ngraham, davidedmundson, plasma-devel, ZrenBot, \
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br \
/></div>



[prev in list] [next in list] [prev in thread] [next in thread]