[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D10197: Fix krunner's alt+f2 on wayland
From:       Martin_Flöser <noreply () phabricator ! kde ! org>
Date:       2018-02-06 5:25:57
Message-ID: 20180206052557.1.3FA28F9F48045B0A () phabricator ! kde ! org
[Download RAW message or body]

graesslin added a comment.


  In https://phabricator.kde.org/D10197#201733, @apol wrote:
  
  > In https://phabricator.kde.org/D10197#200479, @graesslin wrote:
  >
  > > I fear this broke some functionality of KRunner. It is important to be a dock \
window! Otherwise KRunner might not be able to go above fullscreen windows and won't \
be on all desktops. Also without being a PlasmaSurface the manual positioning cannot \
work. If it works for you, I fear it is pure chance.  >
  >
  > Please read before freaking out. As David pointed out the surface code is already \
part of its parent class.  
  
  No it is not. The parent class doesn't support docks - I checked.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10197

To: apol, #plasma, davidedmundson
Cc: graesslin, broulik, ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">graesslin added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D10197" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid \
#8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a \
href="https://phabricator.kde.org/D10197#201733" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">D10197#201733</a>, <a \
href="https://phabricator.kde.org/p/apol/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@apol</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid \
#8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a \
href="https://phabricator.kde.org/D10197#200479" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">D10197#200479</a>, <a \
href="https://phabricator.kde.org/p/graesslin/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@graesslin</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>I fear this broke some functionality of \
KRunner. It is important to be a dock window! Otherwise KRunner might not be able to \
go above fullscreen windows and won&#039;t be on all desktops. Also without being a \
PlasmaSurface the manual positioning cannot work. If it works for you, I fear it is \
pure chance.</p></div> </blockquote>

<p>Please read before freaking out. As David pointed out the surface code is already \
part of its parent class.</p></div> </blockquote>

<p>No it is not. The parent class doesn&#039;t support docks - I \
checked.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D10197" \
rel="noreferrer">https://phabricator.kde.org/D10197</a></div></div><br \
/><div><strong>To: </strong>apol, Plasma, davidedmundson<br /><strong>Cc: \
</strong>graesslin, broulik, ngraham, davidedmundson, plasma-devel, ZrenBot, \
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br \
/></div>



[prev in list] [next in list] [prev in thread] [next in thread]