[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D10188: Sanitise notification HTML
From: David Edmundson <noreply () phabricator ! kde ! org>
Date: 2018-02-02 16:31:58
Message-ID: 20180202163158.1.C8833A18C0D50B3B () phabricator ! kde ! org
[Download RAW message or body]
davidedmundson added inline comments.
INLINE COMMENTS
> broulik wrote in notificationsanitizer.cpp:45
> We need a `QXmlStreamEntityResolver` like `KNotification` has otherwise HTML \
> entities like `Ä` (for `Ä`) will error out.
They don't, because that's not what we're parsing.
We will parse &Auml; which is handled
Sending Ä will get Ä
Sending Ä will show Ä
Old code is the same.
> broulik wrote in notificationsanitizer.cpp:72
> Don't write `alt` if it doesn't have one?
QmlStreamWriter skips it if the value is empty
> broulik wrote in notificationsengine.cpp:265
> Won't you end up with piles of `<html>` tags since `_body` is the body text of the \
> notification it would group to.
> <html>
> <html>
> old notification
> </html>
> new notification
> </html>
>
> Not that it really matters, though.
Oh, I didn't think about that code. You're right.
I'll add a .mid()
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D10188
To: davidedmundson, #plasma, fvogt
Cc: broulik, aacid, fvogt, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart
[Attachment #3 (unknown)]
<table><tr><td style="">davidedmundson added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D10188" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D10188#inline-47438" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">broulik</span> wrote in <span style="color: #4b4d51; font-weight: \
bold;">notificationsanitizer.cpp:45</span></div> <div style="margin: 8px 0; padding: \
0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">We need a <tt \
style="background: #ebebeb; font-size: 13px;">QXmlStreamEntityResolver</tt> like <tt \
style="background: #ebebeb; font-size: 13px;">KNotification</tt> has otherwise HTML \
entities like <tt style="background: #ebebeb; font-size: 13px;">&Auml;</tt> (for \
<tt style="background: #ebebeb; font-size: 13px;">Ä</tt>) will error \
out.</p></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: \
0; margin: 8px;">They don't, because that's not what we're \
parsing.</p>
<p style="padding: 0; margin: 8px;">We will parse &amp;Auml; which is \
handled</p>
<p style="padding: 0; margin: 8px;">Sending Ä will get Ä <br />
Sending &Auml; will show &Auml;</p>
<p style="padding: 0; margin: 8px;">Old code is the same.</p></div></div><br /><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D10188#inline-47437" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: bold;">broulik</span> wrote in \
<span style="color: #4b4d51; font-weight: \
bold;">notificationsanitizer.cpp:72</span></div> <div style="margin: 8px 0; padding: \
0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Don't write <tt \
style="background: #ebebeb; font-size: 13px;">alt</tt> if it doesn't have \
one?</p></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: \
0; margin: 8px;">QmlStreamWriter skips it if the value is empty</p></div></div><br \
/><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D10188#inline-47436" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: bold;">broulik</span> wrote in \
<span style="color: #4b4d51; font-weight: \
bold;">notificationsengine.cpp:265</span></div> <div style="margin: 8px 0; padding: 0 \
12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Won't you end up with \
piles of <tt style="background: #ebebeb; font-size: 13px;"><html></tt> tags \
since <tt style="background: #ebebeb; font-size: 13px;">_body</tt> is the body text \
of the notification it would group to.</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><html> <html>
old notification
</html>
new notification
</html></pre></div>
<p style="padding: 0; margin: 8px;">Not that it really matters, \
though.</p></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p \
style="padding: 0; margin: 8px;">Oh, I didn't think about that code. You're \
right.</p>
<p style="padding: 0; margin: 8px;">I'll add a \
.mid()</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D10188" \
rel="noreferrer">https://phabricator.kde.org/D10188</a></div></div><br \
/><div><strong>To: </strong>davidedmundson, Plasma, fvogt<br /><strong>Cc: \
</strong>broulik, aacid, fvogt, plasma-devel, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic