[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D10197: Fix krunner's alt+f2 on wayland
From:       Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date:       2018-02-02 16:21:16
Message-ID: 20180202162116.1.5C7E0EE801535DA0 () phabricator ! kde ! org
[Download RAW message or body]

broulik added inline comments.

INLINE COMMENTS

> view.cpp:246
> -            m_plasmaShellSurface->setPanelBehavior(PlasmaShellSurface::PanelBehavior::WindowsGoBelow);
>                 
> -            m_plasmaShellSurface->setPanelTakesFocus(true);
> -            m_plasmaShellSurface->setRole(PlasmaShellSurface::Role::Panel);

Don't we still need this somewhere?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10197

To: apol, #plasma, davidedmundson
Cc: broulik, ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">broulik added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D10197" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D10197#inline-47444" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">view.cpp:246</span></div> <div style="font: 11px/15px &quot;Menlo&quot;, \
&quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(251, 175, 175, .7);">            <span \
class="n">m_plasmaShellSurface</span><span style="color: #aa2211">-&gt;</span><span \
class="n">setPanelBehavior</span><span class="p">(</span><span \
class="n">PlasmaShellSurface</span><span style="color: #aa2211">::</span><span \
class="n">PanelBehavior</span><span style="color: #aa2211">::</span><span \
class="n">WindowsGoBelow</span><span class="p">);</span> </div><div style="padding: 0 \
8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">            <span \
class="n">m_plasmaShellSurface</span><span style="color: #aa2211">-&gt;</span><span \
class="n">setPanelTakesFocus</span><span class="p">(</span><span style="color: \
#304a96">true</span><span class="p">);</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(251, 175, 175, .7);">            <span \
class="n">m_plasmaShellSurface</span><span style="color: #aa2211">-&gt;</span><span \
class="n">setRole</span><span class="p">(</span><span \
class="n">PlasmaShellSurface</span><span style="color: #aa2211">::</span><span \
class="n">Role</span><span style="color: #aa2211">::</span><span \
class="n">Panel</span><span class="p">);</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Don&#039;t we still need this somewhere?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D10197" \
rel="noreferrer">https://phabricator.kde.org/D10197</a></div></div><br \
/><div><strong>To: </strong>apol, Plasma, davidedmundson<br /><strong>Cc: \
</strong>broulik, ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]