[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D10170: Added optional transparency/blur to menu frames
From:       Alex Nemeth <noreply () phabricator ! kde ! org>
Date:       2018-02-01 16:09:59
Message-ID: 20180201160959.1.62B89995955DE6E2 () phabricator ! kde ! org
[Download RAW message or body]

anemeth updated this revision to Diff 26329.
anemeth added a comment.


  Now only enabled blur when the frame is transparent.
  
  @hpereiradacosta
  drawPanelMenuPrimitive only runs once per panel creation and not 60 times per \
second, right?  This is what enabled blur behind a window: \
https://github.com/KDE/kwindowsystem/blob/master/src/platforms/xcb/kwindoweffects.cpp#L245
  I don't think it checks if it's already enabled.
  But if it's called only once per panel then it's not an issue.

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10170?vs=26278&id=26329

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10170

AFFECTED FILES
  kstyle/breeze.kcfg
  kstyle/breezestyle.cpp
  kstyle/config/breezestyleconfig.cpp
  kstyle/config/ui/breezestyleconfig.ui

To: anemeth, hpereiradacosta, #plasma, colomar, alake
Cc: fredrik, alake, januz, abetts, colomar, andreask, zzag, ngraham, plasma-devel, \
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">anemeth updated this revision to Diff 26329.<br />anemeth \
added a comment. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 \
8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D10170" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>Now only enabled blur when the frame is \
transparent.</p>

<p><a href="https://phabricator.kde.org/p/hpereiradacosta/" style="
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@hpereiradacosta</a><br />
drawPanelMenuPrimitive only runs once per panel creation and not 60 times per second, \
right?<br /> This is what enabled blur behind a window: <a \
href="https://github.com/KDE/kwindowsystem/blob/master/src/platforms/xcb/kwindoweffects.cpp#L245" \
class="remarkup-link" target="_blank" \
rel="noreferrer">https://github.com/KDE/kwindowsystem/blob/master/src/platforms/xcb/kwindoweffects.cpp#L245</a><br \
/> I don&#039;t think it checks if it&#039;s already enabled.<br />
But if it&#039;s called only once per panel then it&#039;s not an \
issue.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R31 \
Breeze</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a \
href="https://phabricator.kde.org/D10170?vs=26278&amp;id=26329" \
rel="noreferrer">https://phabricator.kde.org/D10170?vs=26278&amp;id=26329</a></div></div><br \
/><div><strong>BRANCH</strong><div><div>master</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D10170" \
rel="noreferrer">https://phabricator.kde.org/D10170</a></div></div><br \
/><div><strong>AFFECTED FILES</strong><div><div>kstyle/breeze.kcfg<br /> \
kstyle/breezestyle.cpp<br /> kstyle/config/breezestyleconfig.cpp<br />
kstyle/config/ui/breezestyleconfig.ui</div></div></div><br /><div><strong>To: \
</strong>anemeth, hpereiradacosta, Plasma, colomar, alake<br /><strong>Cc: \
</strong>fredrik, alake, januz, abetts, colomar, andreask, zzag, ngraham, \
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, \
apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]