[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D10170: Added optional transparency/blur to menu frames
From: Hugo Pereira Da Costa <noreply () phabricator ! kde ! org>
Date: 2018-02-01 12:39:53
Message-ID: 20180201123953.1.5D6A40F18087897F () phabricator ! kde ! org
[Download RAW message or body]
hpereiradacosta added a comment.
In https://phabricator.kde.org/D10170#199003, @fredrik wrote:
> > I think the "blur" option should go. Blur should be controlled centrally by the \
desktop effect. In other words: BlurBehind should always be set to true, and then \
left to kwin to handle. Having an extra option here seems like micro-management. Why \
would you need blur behind plasma widgets (as handled by the desktop effect) and not \
behind menus ? (or vice versa). Also, right now, selecting "blur" in the style \
settings, but unselecting the desktop effect results in no blur behind menu, and \
hence inconsistency with what the style option says. >
> KWin has no way of knowing which pixels should be blurred behind a window. That's \
the reason the hint exists. > If you set the hint unconditionally, the effect will \
be applied unconditionally. Even when the menus are fully opaque.
Correct.
So the call to enableBlurBehind should be made only if "asAlphaChannel" _and_ \
opacity < 1 This still does not need an extra option.
Added comment in the code about this.
Thanks for the clarification.
INLINE COMMENTS
> breezestyle.cpp:3630
> + #if !BREEZE_USE_KDE4
> + KWindowEffects::enableBlurBehind(widget->winId(), true);
> + #endif
This should be called only if StyleConfigData::menuOpacity() is < 100
And in fact, I wonder if it is safe to make the call at every painting call.
I guess it depends on how the underlying function is implemented (does it first check \
for the property ?)
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D10170
To: anemeth, hpereiradacosta, #plasma, colomar, alake
Cc: fredrik, alake, januz, abetts, colomar, andreask, zzag, ngraham, plasma-devel, \
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
[Attachment #3 (unknown)]
<table><tr><td style="">hpereiradacosta added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D10170" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid \
#8C98B8; color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a \
href="https://phabricator.kde.org/D10170#199003" style="background-color: #e7e7e7; \
border-color: #e7e7e7; border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D10170#199003</a>, <a \
href="https://phabricator.kde.org/p/fredrik/" style=" border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@fredrik</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid \
#a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; \
background-color: #f8f9fc;"><p>I think the "blur" option should go. Blur \
should be controlled centrally by the desktop effect. In other words: BlurBehind \
should always be set to true, and then left to kwin to handle. Having an extra option \
here seems like micro-management. Why would you need blur behind plasma widgets (as \
handled by the desktop effect) and not behind menus ? (or vice versa). Also, right \
now, selecting "blur" in the style settings, but unselecting the desktop \
effect results in no blur behind menu, and hence inconsistency with what the style \
option says.</p></blockquote>
<p>KWin has no way of knowing which pixels should be blurred behind a window. \
That's the reason the hint exists.<br /> If you set the hint unconditionally, \
the effect will be applied unconditionally. Even when the menus are fully \
opaque.</p></div> </blockquote>
<p>Correct. <br />
So the call to enableBlurBehind should be made only if "asAlphaChannel" \
_and_ opacity < 1<br /> This still does not need an extra option.<br />
Added comment in the code about this.<br />
Thanks for the clarification.</p></div></div><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D10170#inline-47260" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">breezestyle.cpp:3630</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> #if !BREEZE_USE_KDE4 \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"> KWindowEffects::enableBlurBehind(widget->winId(), true); \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"> #endif </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This \
should be called only if StyleConfigData::menuOpacity() is < 100<br /> And in \
fact, I wonder if it is safe to make the call at every painting call. <br /> I guess \
it depends on how the underlying function is implemented (does it first check for the \
property ?)</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R31 Breeze</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D10170" \
rel="noreferrer">https://phabricator.kde.org/D10170</a></div></div><br \
/><div><strong>To: </strong>anemeth, hpereiradacosta, Plasma, colomar, alake<br \
/><strong>Cc: </strong>fredrik, alake, januz, abetts, colomar, andreask, zzag, \
ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
sebas, apol, mart<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic