[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D10188: Sanitise notification HTML
From:       Albert Astals Cid <noreply () phabricator ! kde ! org>
Date:       2018-01-30 22:44:29
Message-ID: 20180130224429.1.99685D68EA136433 () phabricator ! kde ! org
[Download RAW message or body]

aacid added a comment.


  My hard drive crashed over the weekend so i haven't had much time for anything \
other than trying to salvage stuff from my non-backups, but meanwhile here a stuppid \
"make it const" comment.

INLINE COMMENTS

> notificationsanitizer.cpp:49
> +
> +    QVector<QString> allowedTags = {"b", "i", "u", "img", "a", "html", "br"};
> +

make it const :D

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10188

To: davidedmundson, #plasma, fvogt
Cc: aacid, fvogt, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">aacid added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D10188" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>My hard drive crashed over the weekend so \
i haven&#039;t had much time for anything other than trying to salvage stuff from my \
non-backups, but meanwhile here a stuppid &quot;make it const&quot; \
comment.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D10188#inline-47003" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">notificationsanitizer.cpp:49</span></div> <div style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span \
class="n">QVector</span><span style="color: #aa2211">&lt;</span><span \
class="n">QString</span><span style="color: #aa2211">&gt;</span> <span \
class="n">allowedTags</span> <span style="color: #aa2211">=</span> <span \
class="p">{</span><span style="color: #766510">&quot;b&quot;</span><span \
class="p">,</span> <span style="color: #766510">&quot;i&quot;</span><span \
class="p">,</span> <span style="color: #766510">&quot;u&quot;</span><span \
class="p">,</span> <span style="color: #766510">&quot;img&quot;</span><span \
class="p">,</span> <span style="color: #766510">&quot;a&quot;</span><span \
class="p">,</span> <span style="color: #766510">&quot;html&quot;</span><span \
class="p">,</span> <span style="color: #766510">&quot;br&quot;</span><span \
class="p">};</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">make \
it const :D</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D10188" \
rel="noreferrer">https://phabricator.kde.org/D10188</a></div></div><br \
/><div><strong>To: </strong>davidedmundson, Plasma, fvogt<br /><strong>Cc: \
</strong>aacid, fvogt, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]