[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D10188: Sanitise notification HTML
From:       Fabian Vogt <noreply () phabricator ! kde ! org>
Date:       2018-01-30 15:03:03
Message-ID: 20180130150303.1.3FD2BAE9D7C52229 () phabricator ! kde ! org
[Download RAW message or body]

fvogt added a comment.


  Looks good to me. I didn't try it out myself though, but the unit tests look almost \
complete to me:  
  Can you add a unit test for obviously broken HTML, like `<img src="asdf"` or `<< \
img`?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10188

To: davidedmundson, #plasma, fvogt
Cc: fvogt, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">fvogt added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D10188" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>Looks good to me. I didn&#039;t try it \
out myself though, but the unit tests look almost complete to me:</p>

<p>Can you add a unit test for obviously broken HTML, like <tt style="background: \
#ebebeb; font-size: 13px;">&lt;img src=&quot;asdf&quot;</tt> or <tt \
style="background: #ebebeb; font-size: 13px;">&lt;&lt; img</tt>?</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D10188" \
rel="noreferrer">https://phabricator.kde.org/D10188</a></div></div><br \
/><div><strong>To: </strong>davidedmundson, Plasma, fvogt<br /><strong>Cc: \
</strong>fvogt, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]