[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D6392: [Panel Config] Scrolling over size button increments size by 2 and shows current thickness
From:       Chris Holland <noreply () phabricator ! kde ! org>
Date:       2018-01-31 0:12:49
Message-ID: 20180131001249.1.E9899BAA418DF480 () phabricator ! kde ! org
[Download RAW message or body]

Zren added a comment.


  I do have commit access.
  
  >   Or it could go into master at anytime.
  
  Does this means I can merge to master now (and it'll appear in Plasma 5.13)?
  
  >   only to save in some other unit
  
  As so the plan is to serialize in dpi units? Eg: In units of `pixels / \
units.devicePixelRatio` instead of `pixels`? or something like that? Makes sense.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6392

To: Zren, #plasma, davidedmundson
Cc: ngraham, mmustac, davidedmundson, broulik, plasma-devel, ZrenBot, progwolff, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">Zren added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D6392" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>I do have commit access.</p>

<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: \
italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><div \
class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);">Or it could go into master at \
anytime.</pre></div></blockquote>

<p>Does this means I can merge to master now (and it&#039;ll appear in Plasma \
5.13)?</p>

<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: \
italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><div \
class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);">only to save in some other \
unit</pre></div></blockquote>

<p>As so the plan is to serialize in dpi units? Eg: In units of <tt \
style="background: #ebebeb; font-size: 13px;">pixels / units.devicePixelRatio</tt> \
instead of <tt style="background: #ebebeb; font-size: 13px;">pixels</tt>? or \
something like that? Makes sense.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D6392" \
rel="noreferrer">https://phabricator.kde.org/D6392</a></div></div><br \
/><div><strong>To: </strong>Zren, Plasma, davidedmundson<br /><strong>Cc: \
</strong>ngraham, mmustac, davidedmundson, broulik, plasma-devel, ZrenBot, progwolff, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]