[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D6392: [Panel Config] Scrolling over size button increments size by 2 and shows current thickness
From:       David Edmundson <noreply () phabricator ! kde ! org>
Date:       2018-01-30 11:13:54
Message-ID: 20180130111354.1.5349AC2AB372CD2B () phabricator ! kde ! org
[Download RAW message or body]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Not in 5.12.
  
  I'm not a huge fan, as there's another open bug that the panel should follow the \
Plasma style font-size based sizing. When we have both, presenting something in px, \
only to save in some other unit will lead to somewhat quirky behaviour.  But Kai \
seemed happy and the code looks fine, go for it.  
  Do you have commit access?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6392

To: Zren, #plasma, davidedmundson
Cc: ngraham, mmustac, davidedmundson, broulik, plasma-devel, ZrenBot, progwolff, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">davidedmundson accepted this revision.<br />davidedmundson \
added a comment.<br />This revision is now accepted and ready to land. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D6392" \
rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Not in 5.12.</p>

<p>I&#039;m not a huge fan, as there&#039;s another open bug that the panel should \
follow the Plasma style font-size based sizing. When we have both, presenting \
something in px, only to save in some other unit will lead to somewhat quirky \
behaviour.  But Kai seemed happy and the code looks fine, go for it.</p>

<p>Do you have commit access?</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D6392" \
rel="noreferrer">https://phabricator.kde.org/D6392</a></div></div><br \
/><div><strong>To: </strong>Zren, Plasma, davidedmundson<br /><strong>Cc: \
</strong>ngraham, mmustac, davidedmundson, broulik, plasma-devel, ZrenBot, progwolff, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]