[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D9072: make ksshaskpass work with git-lfs
From:       Martin Koller <noreply () phabricator ! kde ! org>
Date:       2018-01-20 22:49:29
Message-ID: 20180120224929.1.70FCC98C5112C264 () phabricator ! kde ! org
[Download RAW message or body]

mkoller added a comment.


  so you mean instead of a one line change fiddling with file descriptors is a better \
way ?  I don't think so.
  
  And effectively I was told that passing a 0 pointer to kwallet is wrong.
  https://mail.kde.org/pipermail/kde-frameworks-devel/2017-May/045085.html
  
       
  
  - Does kwallet really write to stderr?
  
  yes, using qDebug()
  
  - If so, why does git-lfs parse stderr in addition to stdout?
  
  you have to ask the developers of git-lfs. I don't know.

REPOSITORY
  R105 KDE SSH Password Dialog

REVISION DETAIL
  https://phabricator.kde.org/D9072

To: mkoller, cfeck, jriddell, whiting
Cc: fvogt, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">mkoller added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D9072" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>so you mean instead of a one line change \
fiddling with file descriptors is a better way ?<br /> I don&#039;t think so.</p>

<p>And effectively I was told that passing a 0 pointer to kwallet is wrong.<br />
<a href="https://mail.kde.org/pipermail/kde-frameworks-devel/2017-May/045085.html" \
class="remarkup-link" target="_blank" \
rel="noreferrer">https://mail.kde.org/pipermail/kde-frameworks-devel/2017-May/045085.html</a></p>


<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);"></pre></div>

<ul class="remarkup-list">
<li class="remarkup-list-item">Does kwallet really write to stderr?</li>
</ul>

<p>yes, using qDebug()</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">If so, why does git-lfs parse stderr in addition to \
stdout?</li> </ul>

<p>you have to ask the developers of git-lfs. I don&#039;t know.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R105 KDE SSH Password \
Dialog</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D9072" \
rel="noreferrer">https://phabricator.kde.org/D9072</a></div></div><br \
/><div><strong>To: </strong>mkoller, cfeck, jriddell, whiting<br /><strong>Cc: \
</strong>fvogt, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]