[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D9072: make ksshaskpass work with git-lfs
From:       Fabian Vogt <noreply () phabricator ! kde ! org>
Date:       2018-01-20 16:30:02
Message-ID: 20180120163002.1.840C1BE3CFF8F794 () phabricator ! kde ! org
[Download RAW message or body]

fvogt added a comment.


  In https://phabricator.kde.org/D9072#189550, @mkoller wrote:
  
  > In https://phabricator.kde.org/D9072#189303, @fvogt wrote:
  >
  > > Looks good to me, but I wonder whether
  > >
  > > > KWallet writes an error to stderr when a 0-winId is given to openWallet() \
which is received by git-lfs and aborts the operation.  > >
  > > should be fixed more in a more general way as well.
  >
  >
  > Like how ?
  
  
  Duping stdout/stderr to new file descriptors, using those and closing 1/2 would be \
very effective.  
  Does kwallet really write to stderr? If so, why does git-lfs parse stderr in \
addition to stdout?

REPOSITORY
  R105 KDE SSH Password Dialog

REVISION DETAIL
  https://phabricator.kde.org/D9072

To: mkoller, cfeck, jriddell, whiting
Cc: fvogt, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">fvogt added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D9072" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid \
#8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D9072#189550" \
style="background-color: #e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">D9072#189550</a>, <a \
href="https://phabricator.kde.org/p/mkoller/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@mkoller</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid \
#8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D9072#189303" \
style="background-color: #e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">D9072#189303</a>, <a \
href="https://phabricator.kde.org/p/fvogt/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@fvogt</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>Looks good to me, but I wonder whether</p>

<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: \
italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: \
#f8f9fc;"><p>KWallet writes an error to stderr when a 0-winId is given to \
openWallet() which is received by git-lfs and aborts the operation.</p></blockquote>

<p>should be fixed more in a more general way as well.</p></div>
</blockquote>

<p>Like how ?</p></div>
</blockquote>

<p>Duping stdout/stderr to new file descriptors, using those and closing 1/2 would be \
very effective.</p>

<p>Does kwallet really write to stderr? If so, why does git-lfs parse stderr in \
addition to stdout?</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R105 KDE SSH Password \
Dialog</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D9072" \
rel="noreferrer">https://phabricator.kde.org/D9072</a></div></div><br \
/><div><strong>To: </strong>mkoller, cfeck, jriddell, whiting<br /><strong>Cc: \
</strong>fvogt, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]