[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D8232: Add option to center shadow
From: Andres Betts <noreply () phabricator ! kde ! org>
Date: 2017-12-31 20:13:30
Message-ID: 20171231201330.1.B12C5A1D9201A04B () phabricator ! kde ! org
[Download RAW message or body]
abetts added a comment.
In https://phabricator.kde.org/D8232#184486, @hpereiradacosta wrote:
> In https://phabricator.kde.org/D8232#184470, @abetts wrote:
>
> > In https://phabricator.kde.org/D8232#183783, @ngraham wrote:
> >
> > > Per recent https://phabricator.kde.org/tag/vdg/ discussions, I've put \
together a patch that changes the defaults to horizontally center window and menu \
shadows, and make them a bit larger: https://phabricator.kde.org/D9549 > >
> >
> > Agreed! I think also, we can always experiment and change things going forward. \
I don't think of this patch as the ultimate solution. Just another iteration in an \
evolving theme. >
>
> I would really like to avoid too many iterations on this topic. Window decoration \
are very visible to users, so changing it every two releases gives a really bad \
impression. > We _should_ get it as right as possible before pushing to the \
official repo, sorry. > Andy, if you think the shadow should be improved, please \
indicate how so that the patch gets fixed before its get committed. > Devs can \
work with patches, there is no need to commit.
I mean to say that the shadows are improved with this patch being proposed. I would \
not change anything. My thought is that in future years we can revisit and think if \
we need to make any changes.
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D8232
To: rpelorosso, #breeze, #vdg, hpereiradacosta
Cc: emateli, sebas, januz, alex-l, alake, abetts, progwolff, mvourlakos, rkflx, \
ngraham, davidedmundson, mart, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, apol
[Attachment #3 (unknown)]
<table><tr><td style="">abetts added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D8232" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid \
#8C98B8; color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D8232#184486" \
style="background-color: #e7e7e7; border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D8232#184486</a>, <a \
href="https://phabricator.kde.org/p/hpereiradacosta/" style=" border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@hpereiradacosta</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid \
#8C98B8; color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D8232#184470" \
style="background-color: #e7e7e7; border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D8232#184470</a>, <a \
href="https://phabricator.kde.org/p/abetts/" style=" border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@abetts</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid \
#8C98B8; color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D8232#183783" \
style="background-color: #e7e7e7; border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D8232#183783</a>, <a \
href="https://phabricator.kde.org/p/ngraham/" style=" border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@ngraham</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Per recent <a \
href="https://phabricator.kde.org/tag/vdg/" style="background-color: #e7e7e7; \
border-color: #e7e7e7; border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">#VDG</a> discussions, \
I've put together a patch that changes the defaults to horizontally center \
window and menu shadows, and make them a bit larger: <a \
href="https://phabricator.kde.org/D9549" class="remarkup-link" target="_blank" \
rel="noreferrer">https://phabricator.kde.org/D9549</a></p></div> </blockquote>
<p>Agreed! I think also, we can always experiment and change things going forward. I \
don't think of this patch as the ultimate solution. Just another iteration in an \
evolving theme.</p></div> </blockquote>
<p>I would really like to avoid too many iterations on this topic. Window decoration \
are very visible to users, so changing it every two releases gives a really bad \
impression. <br /> We _should_ get it as right as possible before pushing to the \
official repo, sorry.<br /> Andy, if you think the shadow should be improved, please \
indicate how so that the patch gets fixed before its get committed. <br /> Devs can \
work with patches, there is no need to commit.</p></div> </blockquote>
<p>I mean to say that the shadows are improved with this patch being proposed. I \
would not change anything. My thought is that in future years we can revisit and \
think if we need to make any changes.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R31 Breeze</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8232" \
rel="noreferrer">https://phabricator.kde.org/D8232</a></div></div><br \
/><div><strong>To: </strong>rpelorosso, Breeze, VDG, hpereiradacosta<br /><strong>Cc: \
</strong>emateli, sebas, januz, alex-l, alake, abetts, progwolff, mvourlakos, rkflx, \
ngraham, davidedmundson, mart, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, apol<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic