From kde-panel-devel  Sun Dec 31 20:13:30 2017
From: Andres Betts <noreply () phabricator ! kde ! org>
Date: Sun, 31 Dec 2017 20:13:30 +0000
To: kde-panel-devel
Subject: D8232: Add option to center shadow
Message-Id: <20171231201330.1.B12C5A1D9201A04B () phabricator ! kde ! org>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=151475123125634
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--401be58e02744c4c9a115f1525c9cf9f"

--401be58e02744c4c9a115f1525c9cf9f
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="ascii"
Mime-Version: 1.0

abetts added a comment.


  In https://phabricator.kde.org/D8232#184486, @hpereiradacosta wrote:
  
  > In https://phabricator.kde.org/D8232#184470, @abetts wrote:
  >
  > > In https://phabricator.kde.org/D8232#183783, @ngraham wrote:
  > >
  > > > Per recent https://phabricator.kde.org/tag/vdg/ discussions, I've put together a patch that changes the defaults to horizontally center window and menu shadows, and make them a bit larger: https://phabricator.kde.org/D9549
  > >
  > >
  > > Agreed! I think also, we can always experiment and change things going forward. I don't think of this patch as the ultimate solution. Just another iteration in an evolving theme.
  >
  >
  > I would really like to avoid too many iterations on this topic. Window decoration are very visible to users, so changing it every two releases gives a really bad impression. 
  >  We _should_ get it as right as possible before pushing to the official repo, sorry.
  >  Andy, if you think the shadow should be improved, please indicate how so that the patch gets fixed before its get committed. 
  >  Devs can work with patches, there is no need to commit.
  
  
  I mean to say that the shadows are improved with this patch being proposed. I would not change anything. My thought is that in future years we can revisit and think if we need to make any changes.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D8232

To: rpelorosso, #breeze, #vdg, hpereiradacosta
Cc: emateli, sebas, januz, alex-l, alake, abetts, progwolff, mvourlakos, rkflx, ngraham, davidedmundson, mart, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, apol

--401be58e02744c4c9a115f1525c9cf9f
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html; charset="ascii"
Mime-Version: 1.0

<table><tr><td style=3D"">abetts added a comment.
</td><a style=3D"text-decoration: none; padding: 4px 8px; margin: 0 8px 8px=
; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; back=
ground-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1=
f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href=
=3D"https://phabricator.kde.org/D8232" rel=3D"noreferrer">View Revision</a>=
</tr></table><br /><div><div><blockquote style=3D"border-left: 3px solid #8=
C98B8;
          color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style=3D"font-style: normal;
          padding-bottom: 4px;">In <a href=3D"https://phabricator.kde.org/D=
8232#184486" style=3D"background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel=3D"noreferrer">D8232#184=
486</a>, <a href=3D"https://phabricator.kde.org/p/hpereiradacosta/" style=
=3D"
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel=3D"noreferrer">@hpereiradacosta</a> wr=
ote:</div>
<div style=3D"margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><blockquote style=3D"border-left: 3px=
 solid #8C98B8;
          color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style=3D"font-style: normal;
          padding-bottom: 4px;">In <a href=3D"https://phabricator.kde.org/D=
8232#184470" style=3D"background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel=3D"noreferrer">D8232#184=
470</a>, <a href=3D"https://phabricator.kde.org/p/abetts/" style=3D"
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel=3D"noreferrer">@abetts</a> wrote:</div>
<div style=3D"margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><blockquote style=3D"border-left: 3px=
 solid #8C98B8;
          color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style=3D"font-style: normal;
          padding-bottom: 4px;">In <a href=3D"https://phabricator.kde.org/D=
8232#183783" style=3D"background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel=3D"noreferrer">D8232#183=
783</a>, <a href=3D"https://phabricator.kde.org/p/ngraham/" style=3D"
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel=3D"noreferrer">@ngraham</a> wrote:</di=
v>
<div style=3D"margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>Per recent <a href=3D"https://phab=
ricator.kde.org/tag/vdg/" style=3D"background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel=3D"noreferrer">#VDG</a> =
discussions, I&#039;ve put together a patch that changes the defaults to ho=
rizontally center window and menu shadows, and make them a bit larger: <a h=
ref=3D"https://phabricator.kde.org/D9549" class=3D"remarkup-link" target=3D=
"_blank" rel=3D"noreferrer">https://phabricator.kde.org/D9549</a></p></div>
</blockquote>

<p>Agreed! I think also, we can always experiment and change things going f=
orward. I don&#039;t think of this patch as the ultimate solution. Just ano=
ther iteration in an evolving theme.</p></div>
</blockquote>

<p>I would really like to avoid too many iterations on this topic. Window d=
ecoration are very visible to users, so changing it every two releases give=
s a really bad impression. <br />
 We _should_ get it as right as possible before pushing to the official rep=
o, sorry.<br />
 Andy, if you think the shadow should be improved, please indicate how so t=
hat the patch gets fixed before its get committed. <br />
 Devs can work with patches, there is no need to commit.</p></div>
</blockquote>

<p>I mean to say that the shadows are improved with this patch being propos=
ed. I would not change anything. My thought is that in future years we can =
revisit and think if we need to make any changes.</p></div></div><br /><div=
><strong>REPOSITORY</strong><div><div>R31 Breeze</div></div></div><br /><di=
v><strong>REVISION DETAIL</strong><div><a href=3D"https://phabricator.kde.o=
rg/D8232" rel=3D"noreferrer">https://phabricator.kde.org/D8232</a></div></d=
iv><br /><div><strong>To: </strong>rpelorosso, Breeze, VDG, hpereiradacosta=
<br /><strong>Cc: </strong>emateli, sebas, januz, alex-l, alake, abetts, pr=
ogwolff, mvourlakos, rkflx, ngraham, davidedmundson, mart, plasma-devel, Zr=
enBot, lesliezhai, ali-mohamed, jensreuterberg, apol<br /></div>
--401be58e02744c4c9a115f1525c9cf9f--