[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D9070: KDE platform plugin: don't force default stylename on user-specified fonts
From:       René J.V. Bertin <noreply () phabricator ! kde ! org>
Date:       2017-12-30 17:23:16
Message-ID: 20171230172316.1.D34D38472003DBDE () phabricator ! kde ! org
[Download RAW message or body]

rjvbb added a comment.


  >   So this this actually resolve https://bugs.kde.org/show_bug.cgi?id=378523, or \
just lay the groundwork for resolving it?  
  No, it's more a change similar to proposed fix for that bug (don't set a stylename \
in KFontRequester).  This patch implements the principle that you shouldn't set a \
style name if you cannot guarantee that the side-effects of that change are without \
consequence. The platform theme plugin loads the desktop fonts and if it imposes a \
style name on them no application can set them to bold or italic anymore.  
  So you could say that this patch is necessary for the KFontRequester fix to work as \
intended (as far as the desktop fonts are concerned).

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D9070

To: rjvbb, #frameworks, davidedmundson, graesslin, cfeck, dfaure
Cc: anthonyfieroni, ngraham, cfeck, fvogt, plasma-devel, ZrenBot, progwolff, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">rjvbb added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D9070" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid \
#a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; \
background-color: #f8f9fc;"><div class="remarkup-code-block" style="margin: 12px 0;" \
data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" \
style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, \
monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">So this \
this actually resolve https://bugs.kde.org/show_bug.cgi?id=378523, or just lay the \
groundwork for resolving it?</pre></div></blockquote>

<p>No, it&#039;s more a change similar to proposed fix for that bug (don&#039;t set a \
stylename in KFontRequester).<br /> This patch implements the principle that you \
shouldn&#039;t set a style name if you cannot guarantee that the side-effects of that \
change are without consequence. The platform theme plugin loads the desktop fonts and \
if it imposes a style name on them no application can set them to bold or italic \
anymore.</p>

<p>So you could say that this patch is necessary for the KFontRequester fix to work \
as intended (as far as the desktop fonts are concerned).</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R135 Integration for Qt applications in \
Plasma</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D9070" \
rel="noreferrer">https://phabricator.kde.org/D9070</a></div></div><br \
/><div><strong>To: </strong>rjvbb, Frameworks, davidedmundson, graesslin, cfeck, \
dfaure<br /><strong>Cc: </strong>anthonyfieroni, ngraham, cfeck, fvogt, plasma-devel, \
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, \
mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]