--a4abe945d3fb446bbf0ed2ebb3f5afb8
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="ascii"
Mime-Version: 1.0

rjvbb added a comment.


  >   So this this actually resolve https://bugs.kde.org/show_bug.cgi?id=378523, or just lay the groundwork for resolving it?
  
  No, it's more a change similar to proposed fix for that bug (don't set a stylename in KFontRequester).
  This patch implements the principle that you shouldn't set a style name if you cannot guarantee that the side-effects of that change are without consequence. The platform theme plugin loads the desktop fonts and if it imposes a style name on them no application can set them to bold or italic anymore.
  
  So you could say that this patch is necessary for the KFontRequester fix to work as intended (as far as the desktop fonts are concerned).

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D9070

To: rjvbb, #frameworks, davidedmundson, graesslin, cfeck, dfaure
Cc: anthonyfieroni, ngraham, cfeck, fvogt, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

--a4abe945d3fb446bbf0ed2ebb3f5afb8
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html; charset="ascii"
Mime-Version: 1.0

<table><tr><td style=3D"">rjvbb added a comment.
</td><a style=3D"text-decoration: none; padding: 4px 8px; margin: 0 8px 8px=
; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; back=
ground-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1=
f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href=
=3D"https://phabricator.kde.org/D9070" rel=3D"noreferrer">View Revision</a>=
</tr></table><br /><div><div><blockquote style=3D"border-left: 3px solid #a=
7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4=
px 12px; background-color: #f8f9fc;"><div class=3D"remarkup-code-block" sty=
le=3D"margin: 12px 0;" data-code-lang=3D"text" data-sigil=3D"remarkup-code-=
block"><pre class=3D"remarkup-code" style=3D"font: 11px/15px &quot;Menlo&qu=
ot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; padding: 12px; ma=
rgin: 0; background: rgba(71, 87, 120, 0.08);">So this this actually resolv=
e https://bugs.kde.org/show_bug.cgi?id=3D378523, or just lay the groundwork=
 for resolving it?</pre></div></blockquote>

<p>No, it&#039;s more a change similar to proposed fix for that bug (don&#0=
39;t set a stylename in KFontRequester).<br />
This patch implements the principle that you shouldn&#039;t set a style nam=
e if you cannot guarantee that the side-effects of that change are without =
consequence. The platform theme plugin loads the desktop fonts and if it im=
poses a style name on them no application can set them to bold or italic an=
ymore.</p>

<p>So you could say that this patch is necessary for the KFontRequester fix=
 to work as intended (as far as the desktop fonts are concerned).</p></div>=
</div><br /><div><strong>REPOSITORY</strong><div><div>R135 Integration for =
Qt applications in Plasma</div></div></div><br /><div><strong>REVISION DETA=
IL</strong><div><a href=3D"https://phabricator.kde.org/D9070" rel=3D"norefe=
rrer">https://phabricator.kde.org/D9070</a></div></div><br /><div><strong>T=
o: </strong>rjvbb, Frameworks, davidedmundson, graesslin, cfeck, dfaure<br =
/><strong>Cc: </strong>anthonyfieroni, ngraham, cfeck, fvogt, plasma-devel,=
 ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas=
, apol, mart<br /></div>
--a4abe945d3fb446bbf0ed2ebb3f5afb8--