[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D7246: Tooltips
From:       Martin_Flöser <noreply () phabricator ! kde ! org>
Date:       2017-12-29 16:55:54
Message-ID: 20171229165554.1.EF6C69D75FAD4F7D () phabricator ! kde ! org
[Download RAW message or body]

graesslin added inline comments.

INLINE COMMENTS

> McPain wrote in decoratedclientprivate.h:79-80
> I need to avoid sover increasing, right?

No, increasing the soversion of the private library is fine. It's only used by KWin \
and by KDecoration public library. The interface to the decoration plugins (like \
breeze) is still stable. As KDecoration and KWin are released together it's not a \
problem. But we should try to get it in before the beta release as distros might need \
to adjust packaging.

REPOSITORY
  R129 Window Decoration Library

REVISION DETAIL
  https://phabricator.kde.org/D7246

To: McPain, #breeze, #plasma, graesslin
Cc: ngraham, broulik, plasma-devel, #breeze, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">graesslin added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D7246" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D7246#inline-43141" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">McPain</span> wrote in <span style="color: #4b4d51; font-weight: \
bold;">decoratedclientprivate.h:79-80</span></div> <div style="margin: 8px 0; \
padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">I need to avoid \
sover increasing, right?</p></div></div> <div style="margin: 8px 0; padding: 0 \
12px;"><p style="padding: 0; margin: 8px;">No, increasing the soversion of the \
private library is fine. It&#039;s only used by KWin and by KDecoration public \
library. The interface to the decoration plugins (like breeze) is still stable. As \
KDecoration and KWin are released together it&#039;s not a problem. But we should try \
to get it in before the beta release as distros might need to adjust \
packaging.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R129 Window Decoration \
Library</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D7246" \
rel="noreferrer">https://phabricator.kde.org/D7246</a></div></div><br \
/><div><strong>To: </strong>McPain, Breeze, Plasma, graesslin<br /><strong>Cc: \
</strong>ngraham, broulik, plasma-devel, Breeze, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]