From kde-panel-devel  Fri Dec 29 16:55:54 2017
From: =?utf-8?q?Martin_Fl=C3=B6ser?= <noreply () phabricator ! kde ! org>
Date: Fri, 29 Dec 2017 16:55:54 +0000
To: kde-panel-devel
Subject: D7246: Tooltips
Message-Id: <20171229165554.1.EF6C69D75FAD4F7D () phabricator ! kde ! org>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=151456656528440
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--63f73ef57b094bd38f346cbad59c5f5d"

--63f73ef57b094bd38f346cbad59c5f5d
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="ascii"
Mime-Version: 1.0

graesslin added inline comments.

INLINE COMMENTS

> McPain wrote in decoratedclientprivate.h:79-80
> I need to avoid sover increasing, right?

No, increasing the soversion of the private library is fine. It's only used by KWin and by KDecoration public library. The interface to the decoration plugins (like breeze) is still stable. As KDecoration and KWin are released together it's not a problem. But we should try to get it in before the beta release as distros might need to adjust packaging.

REPOSITORY
  R129 Window Decoration Library

REVISION DETAIL
  https://phabricator.kde.org/D7246

To: McPain, #breeze, #plasma, graesslin
Cc: ngraham, broulik, plasma-devel, #breeze, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

--63f73ef57b094bd38f346cbad59c5f5d
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html; charset="ascii"
Mime-Version: 1.0

<table><tr><td style=3D"">graesslin added inline comments.
</td><a style=3D"text-decoration: none; padding: 4px 8px; margin: 0 8px 8px=
; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; back=
ground-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1=
f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href=
=3D"https://phabricator.kde.org/D7246" rel=3D"noreferrer">View Revision</a>=
</tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style=3D"=
margin: 6px 0 12px 0;"><div style=3D"border: 1px solid #C7CCD9; border-radi=
us: 3px;"><div style=3D"padding: 0; background: #F7F7F7; border-color: #e3e=
4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style=
=3D"color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden=
;"><a style=3D"float: right; text-decoration: none;" href=3D"https://phabri=
cator.kde.org/D7246#inline-43141" rel=3D"noreferrer">View Inline</a><span s=
tyle=3D"color: #4b4d51; font-weight: bold;">McPain</span> wrote in <span st=
yle=3D"color: #4b4d51; font-weight: bold;">decoratedclientprivate.h:79-80</=
span></div>
<div style=3D"margin: 8px 0; padding: 0 12px; color: #74777D;"><p style=3D"=
padding: 0; margin: 8px;">I need to avoid sover increasing, right?</p></div=
></div>
<div style=3D"margin: 8px 0; padding: 0 12px;"><p style=3D"padding: 0; marg=
in: 8px;">No, increasing the soversion of the private library is fine. It&#=
039;s only used by KWin and by KDecoration public library. The interface to=
 the decoration plugins (like breeze) is still stable. As KDecoration and K=
Win are released together it&#039;s not a problem. But we should try to get=
 it in before the beta release as distros might need to adjust packaging.</=
p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div>=
<div>R129 Window Decoration Library</div></div></div><br /><div><strong>REV=
ISION DETAIL</strong><div><a href=3D"https://phabricator.kde.org/D7246" rel=
=3D"noreferrer">https://phabricator.kde.org/D7246</a></div></div><br /><div=
><strong>To: </strong>McPain, Breeze, Plasma, graesslin<br /><strong>Cc: </=
strong>ngraham, broulik, plasma-devel, Breeze, ZrenBot, progwolff, lesliezh=
ai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>
--63f73ef57b094bd38f346cbad59c5f5d--