[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D8673: Sanitize signal handling in ksmserver
From:       Martin_Flöser <noreply () phabricator ! kde ! org>
Date:       2017-11-30 19:02:23
Message-ID: 20171130190223.130552.5D2D6BDE26181EED () phabricator ! kde ! org
[Download RAW message or body]

graesslin added inline comments.

INLINE COMMENTS

> server.cpp:615
> +    QSocketNotifier* n = new QSocketNotifier(sockets[1], QSocketNotifier::Read, \
> this); +    qApp->connect(n, SIGNAL(activated(int)), SLOT(quit()));
> +

why the old connect syntax?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D8673

To: jpalecek, #plasma
Cc: graesslin, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">graesslin added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D8673" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D8673#inline-40841" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">server.cpp:615</span></div> <div style="font: 11px/15px &quot;Menlo&quot;, \
&quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);">    <span class="n">QSocketNotifier</span><span \
style="color: #aa2211">*</span> <span class="n">n</span> <span style="color: \
#aa2211">=</span> <span style="color: #aa4000">new</span> <span \
class="n">QSocketNotifier</span><span class="p">(</span><span \
class="n">sockets</span><span class="p">[</span><span style="color: \
#601200">1</span><span class="p">],</span> <span \
class="n">QSocketNotifier</span><span style="color: #aa2211">::</span><span \
class="n">Read</span><span class="p">,</span> <span style="color: \
#aa4000">this</span><span class="p">);</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span \
class="n">qApp</span><span style="color: #aa2211">-&gt;</span><span \
class="n">connect</span><span class="p">(</span><span class="n">n</span><span \
class="p">,</span> <span class="n">SIGNAL</span><span class="p">(</span><span \
class="n">activated</span><span class="p">(</span><span style="color: \
#aa4000">int</span><span class="p">)),</span> <span class="n">SLOT</span><span \
class="p">(</span><span class="n">quit</span><span class="p">()));</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">why the old connect syntax?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8673" \
rel="noreferrer">https://phabricator.kde.org/D8673</a></div></div><br \
/><div><strong>To: </strong>jpalecek, Plasma<br /><strong>Cc: </strong>graesslin, \
davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]