From kde-panel-devel  Thu Nov 30 19:02:23 2017
From: =?utf-8?q?Martin_Fl=C3=B6ser?= <noreply () phabricator ! kde ! org>
Date: Thu, 30 Nov 2017 19:02:23 +0000
To: kde-panel-devel
Subject: D8673: Sanitize signal handling in ksmserver
Message-Id: <20171130190223.130552.5D2D6BDE26181EED () phabricator ! kde ! org>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=151206855711340
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--76e65cf4aec84ae4827414c3369d5e35"

--76e65cf4aec84ae4827414c3369d5e35
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="ascii"
Mime-Version: 1.0

graesslin added inline comments.

INLINE COMMENTS

> server.cpp:615
> +    QSocketNotifier* n = new QSocketNotifier(sockets[1], QSocketNotifier::Read, this);
> +    qApp->connect(n, SIGNAL(activated(int)), SLOT(quit()));
> +

why the old connect syntax?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D8673

To: jpalecek, #plasma
Cc: graesslin, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

--76e65cf4aec84ae4827414c3369d5e35
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html; charset="ascii"
Mime-Version: 1.0

<table><tr><td style=3D"">graesslin added inline comments.
</td><a style=3D"text-decoration: none; padding: 4px 8px; margin: 0 8px 8px=
; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; back=
ground-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1=
f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href=
=3D"https://phabricator.kde.org/D8673" rel=3D"noreferrer">View Revision</a>=
</tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style=3D"=
margin: 6px 0 12px 0;"><div style=3D"border: 1px solid #C7CCD9; border-radi=
us: 3px;"><div style=3D"padding: 0; background: #F7F7F7; border-color: #e3e=
4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style=
=3D"color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden=
;"><a style=3D"float: right; text-decoration: none;" href=3D"https://phabri=
cator.kde.org/D8673#inline-40841" rel=3D"noreferrer">View Inline</a><span s=
tyle=3D"color: #4b4d51; font-weight: bold;">server.cpp:615</span></div>
<div style=3D"font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quo=
t;Monaco&quot;, monospace; white-space: pre-wrap; clear: both; padding: 4px=
 0; margin: 0;"><div style=3D"padding: 0 8px; margin: 0 4px; background: rg=
ba(151, 234, 151, .6);">    <span class=3D"n">QSocketNotifier</span><span s=
tyle=3D"color: #aa2211">*</span> <span class=3D"n">n</span> <span style=3D"=
color: #aa2211">=3D</span> <span style=3D"color: #aa4000">new</span> <span =
class=3D"n">QSocketNotifier</span><span class=3D"p">(</span><span class=3D"=
n">sockets</span><span class=3D"p">[</span><span style=3D"color: #601200">1=
</span><span class=3D"p">],</span> <span class=3D"n">QSocketNotifier</span>=
<span style=3D"color: #aa2211">::</span><span class=3D"n">Read</span><span =
class=3D"p">,</span> <span style=3D"color: #aa4000">this</span><span class=
=3D"p">);</span>
</div><div style=3D"padding: 0 8px; margin: 0 4px; background: rgba(151, 23=
4, 151, .6);">    <span class=3D"n">qApp</span><span style=3D"color: #aa221=
1">-&gt;</span><span class=3D"n">connect</span><span class=3D"p">(</span><s=
pan class=3D"n">n</span><span class=3D"p">,</span> <span class=3D"n">SIGNAL=
</span><span class=3D"p">(</span><span class=3D"n">activated</span><span cl=
ass=3D"p">(</span><span style=3D"color: #aa4000">int</span><span class=3D"p=
">)),</span> <span class=3D"n">SLOT</span><span class=3D"p">(</span><span c=
lass=3D"n">quit</span><span class=3D"p">()));</span>
</div></div></div>
<div style=3D"margin: 8px 0; padding: 0 12px;"><p style=3D"padding: 0; marg=
in: 8px;">why the old connect syntax?</p></div></div></div></div></div><br =
/><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></di=
v></div><br /><div><strong>REVISION DETAIL</strong><div><a href=3D"https://=
phabricator.kde.org/D8673" rel=3D"noreferrer">https://phabricator.kde.org/D=
8673</a></div></div><br /><div><strong>To: </strong>jpalecek, Plasma<br /><=
strong>Cc: </strong>graesslin, davidedmundson, plasma-devel, ZrenBot, progw=
olff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br=
 /></div>
--76e65cf4aec84ae4827414c3369d5e35--