[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D9040: Revert "[Lock Screen / Login] Add "reveal password button""
From:       David Edmundson <noreply () phabricator ! kde ! org>
Date:       2017-11-29 22:43:49
Message-ID: 20171129224349.119722.04D7A55100B049B7 () phabricator ! kde ! org
[Download RAW message or body]

davidedmundson added a comment.


  If the icon is not fixed in the login screen, I'm definitely pushing the SDDM side \
for 5.12.   An invisible hit area is not usability.
  
  As for the lock screen:
  
  - the rationale for introducing was originally consistency, it isn't.
  - The virtual keyboard is a relevant point, which we should do something with.
  
  A button that a user has to press every single time isn't an ideal solution. If \
visual feedback is needed, visual feedback is needed.  
  Ideally we do want that echo mode that Nate described (PasswordEchoOnEdit \
unfortuantely isn't it) then switch between them based on whether we're showing the \
input panel.  
  I'll try and look into that.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9040

To: davidedmundson, broulik
Cc: graesslin, ngraham, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">davidedmundson added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D9040" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>If the icon is not fixed in the login \
screen, I&#039;m definitely pushing the SDDM side for 5.12. <br /> An invisible hit \
area is not usability.</p>

<p>As for the lock screen:</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">the rationale for introducing was originally \
consistency, it isn&#039;t.</li> <li class="remarkup-list-item">The virtual keyboard \
is a relevant point, which we should do something with.</li> </ul>

<p>A button that a user has to press every single time isn&#039;t an ideal solution. \
If visual feedback is needed, visual feedback is needed.</p>

<p>Ideally we do want that echo mode that Nate described (PasswordEchoOnEdit \
unfortuantely isn&#039;t it) then switch between them based on whether we&#039;re \
showing the input panel.</p>

<p>I&#039;ll try and look into that.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>master</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D9040" \
rel="noreferrer">https://phabricator.kde.org/D9040</a></div></div><br \
/><div><strong>To: </strong>davidedmundson, broulik<br /><strong>Cc: \
</strong>graesslin, ngraham, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]