[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D8787: Fix PWD dialog
From:       Kees vd Broek <noreply () phabricator ! kde ! org>
Date:       2017-11-29 9:47:45
Message-ID: 20171129094745.5547.95E6FCD9BAE89858 () phabricator ! kde ! org
[Download RAW message or body]

cryptodude added a comment.


  Welcome back :)
  
  > Replace the text in the 'error' label with 'Failed to open: %1'
  
  Ah, that is an improvement indeed. Will do.
  
  > Replace the two labels with a single one
  
  Let me explain why I separated them, then you can decide if it was a good call or \
you still want to have it in one label.  The patch I created has one text and one \
label which we hard-code and translate. It is important that this text is used to set \
the width of the dialog.  The second label is essentially user-provided. The actual \
vault name. I set that label to have its width ignored, as such if the user sets a \
1000 char name, this will not grow the window width.  
  As such, your suggestion combined with a very wide vault name would end up making \
the dialog bigger, potentially even making the Ok button invisible (out of screen).

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D8787

To: cryptodude, #plasma, ivan
Cc: ngraham, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">cryptodude added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D8787" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>Welcome back :)</p>

<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: \
italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: \
#f8f9fc;"><p>Replace the text in the &#039;error&#039; label with &#039;Failed to \
open: %1&#039;</p></blockquote>

<p>Ah, that is an improvement indeed. Will do.</p>

<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: \
italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: \
#f8f9fc;"><p>Replace the two labels with a single one</p></blockquote>

<p>Let me explain why I separated them, then you can decide if it was a good call or \
you still want to have it in one label.<br /> The patch I created has one text and \
one label which we hard-code and translate. It is important that this text is used to \
set the width of the dialog.<br /> The second label is essentially user-provided. The \
actual vault name. I set that label to have its width ignored, as such if the user \
sets a 1000 char name, this will not grow the window width.</p>

<p>As such, your suggestion combined with a very wide vault name would end up making \
the dialog bigger, potentially even making the Ok button invisible (out of \
screen).</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R845 Plasma \
Vault</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8787" \
rel="noreferrer">https://phabricator.kde.org/D8787</a></div></div><br \
/><div><strong>To: </strong>cryptodude, Plasma, ivan<br /><strong>Cc: \
</strong>ngraham, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]