[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D8787: Fix PWD dialog
From:       Ivan Čukić <noreply () phabricator ! kde ! org>
Date:       2017-11-29 8:04:40
Message-ID: 20171129080440.129383.AF6103DA312F0944 () phabricator ! kde ! org
[Download RAW message or body]

ivan added a comment.


  Almost mergeable - I just have a few nit-picks:
  
  - Replace the two labels with  a single one "Please enter the password to open the \
                \"%1\" vault" (this will also remove the need for the leading space)
  - Replace the text in the 'error' label with 'Failed to open: %1'
  
  We should also add an 'in progress' state, but that can be a separate patch

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D8787

To: cryptodude, #plasma, ivan
Cc: ngraham, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">ivan added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D8787" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>Almost mergeable - I just have a few \
nit-picks:</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">Replace the two labels with  a single one &quot;Please \
enter the password to open the \&quot;%1\&quot; vault&quot; (this will also remove \
the need for the leading space)</li> <li class="remarkup-list-item">Replace the text \
in the &#039;error&#039; label with &#039;Failed to open: %1&#039;</li> </ul>

<p>We should also add an &#039;in progress&#039; state, but that can be a separate \
patch</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R845 Plasma \
Vault</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8787" \
rel="noreferrer">https://phabricator.kde.org/D8787</a></div></div><br \
/><div><strong>To: </strong>cryptodude, Plasma, ivan<br /><strong>Cc: \
</strong>ngraham, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]