[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D8082: Also send Wayland clients to a new desktop if their desktop was removed
From:       Martin_Flöser <noreply () phabricator ! kde ! org>
Date:       2017-10-01 9:04:21
Message-ID: differential-rev-PHID-DREV-wicrqkjc2franwru7my4-req () phabricator ! kde ! org
[Download RAW message or body]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  So far the method only operated on X11 clients. So when the last desktop
  got removed Wayland clients were still on it. As the auto test showed:
  this results in a crash.
  
  Credits go to code coverage as it showed that area as red, which made me
  look on it and realize this must be broken.

TEST PLAN
  New test case added

REPOSITORY
  R108 KWin

BRANCH
  virtual-desktop-remove-send-client-5.11

REVISION DETAIL
  https://phabricator.kde.org/D8082

AFFECTED FILES
  autotests/integration/CMakeLists.txt
  autotests/integration/virtual_desktop_test.cpp
  workspace.cpp

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
hardening, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">graesslin created this revision.<br />graesslin added \
reviewers: KWin, Plasma.<br />Restricted Application added a project: KWin.<br \
/>Restricted Application added subscribers: kwin, plasma-devel. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8082" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION \
SUMMARY</strong><div><p>So far the method only operated on X11 clients. So when the \
last desktop<br /> got removed Wayland clients were still on it. As the auto test \
showed:<br /> this results in a crash.</p>

<p>Credits go to code coverage as it showed that area as red, which made me<br />
look on it and realize this must be broken.</p></div></div><br /><div><strong>TEST \
PLAN</strong><div><p>New test case added</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>virtual-desktop-remove-send-client-5.11</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8082" \
rel="noreferrer">https://phabricator.kde.org/D8082</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>autotests/integration/CMakeLists.txt<br /> \
autotests/integration/virtual_desktop_test.cpp<br /> \
workspace.cpp</div></div></div><br /><div><strong>To: </strong>graesslin, KWin, \
Plasma<br /><strong>Cc: </strong>plasma-devel, kwin, bwowk, ZrenBot, progwolff, \
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart<br \
/></div>



[prev in list] [next in list] [prev in thread] [next in thread]