[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D8077: Fix org.kde.plasma.calendar with Qt 5.10
From:       Fabian Vogt <noreply () phabricator ! kde ! org>
Date:       2017-09-30 17:11:33
Message-ID: differential-rev-PHID-DREV-w5jnjjxk3fvgysl7a3up-req () phabricator ! kde ! org
[Download RAW message or body]

fvogt created this revision.
fvogt added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  Module internal types are not implicitly available anymore simply by placing
  them inside the module's main directory. It is now necessary to mention them
  as internal types in the qmldir file.
  
  See qtdeclarative commits 22a2cc43387ec3b9f74a6c01f8665378a4541147 (introduced
  the change) and 930aea8b9ca59a24838cf7f279653e3b2ee40cee (explanation)

TEST PLAN
  Built whole stack with Qt 5.10. The digital clock plasmoid does not
  load due to the DaysCalendar type not being available. With these changes to
  qmldir and a reload of the plasmoid it works.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8077

AFFECTED FILES
  src/declarativeimports/calendar/qml/qmldir

To: fvogt, #plasma
Cc: #frameworks, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">fvogt created this revision.<br />fvogt added a reviewer: \
Plasma.<br />Restricted Application added projects: Plasma, Frameworks.<br \
/>Restricted Application added a subscriber: Frameworks. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8077" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION \
SUMMARY</strong><div><p>Module internal types are not implicitly available anymore \
simply by placing<br /> them inside the module&#039;s main directory. It is now \
necessary to mention them<br /> as internal types in the qmldir file.</p>

<p>See qtdeclarative commits 22a2cc43387ec3b9f74a6c01f8665378a4541147 (introduced<br \
/> the change) and 930aea8b9ca59a24838cf7f279653e3b2ee40cee \
(explanation)</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Built whole \
stack with Qt 5.10. The digital clock plasmoid does not<br /> load due to the \
DaysCalendar type not being available. With these changes to<br /> qmldir and a \
reload of the plasmoid it works.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework \
(Library)</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>master</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8077" \
rel="noreferrer">https://phabricator.kde.org/D8077</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>src/declarativeimports/calendar/qml/qmldir</div></div></div><br \
/><div><strong>To: </strong>fvogt, Plasma<br /><strong>Cc: </strong>Frameworks, \
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, \
sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]