[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D8039: Support software QtQuickRendering in Aurorae
From: David Edmundson <noreply () phabricator ! kde ! org>
Date: 2017-09-29 16:02:50
Message-ID: 20170929160135.75244.C89704261930F02B () phabricator ! kde ! org
[Download RAW message or body]
davidedmundson added inline comments.
INLINE COMMENTS
> apol wrote in aurorae.cpp:344
> `#if QT_VERSION < QT_VERSION_CHECK(5,10,0)`?
Yeah, makes sense, it got +2'd quicker than I expected.
> graesslin wrote in aurorae.cpp:354
> stupid question: but why is this code working? I would assume that making the \
> context current will fail here and then we return? And even if the creation of the \
> FBO should fail and then also return?
Changing the rendering doesn't block making calls to any of the openGL calls in \
QtBase. The only changes are purely inside QtQuick
So:
creating a context still works fine
creating an FBO still works fine
why m_view->setRenderTarget and m_view->resetOpenGLState still work are the more \
interesting questions but that's because they're virtual methods that no-op.
With this code:
we create an OpenGL context
set it to be active
then ignore it and do something completely different with QPainter instead
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D8039
To: davidedmundson, #plasma
Cc: graesslin, apol, plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff, \
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, mart
[Attachment #3 (unknown)]
<table><tr><td style="">davidedmundson added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D8039" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D8039#inline-33429" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">apol</span> wrote in <span style="color: #4b4d51; font-weight: \
bold;">aurorae.cpp:344</span></div> <div style="margin: 8px 0; padding: 0 12px; \
color: #74777D;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; \
font-size: 13px;">#if QT_VERSION < QT_VERSION_CHECK(5,10,0)</tt>?</p></div></div> \
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Yeah, makes sense, it got +2'd quicker than I expected.</p></div></div><br \
/><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D8039#inline-33545" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: bold;">graesslin</span> wrote in \
<span style="color: #4b4d51; font-weight: bold;">aurorae.cpp:354</span></div> <div \
style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: \
8px;">stupid question: but why is this code working? I would assume that making the \
context current will fail here and then we return? And even if the creation of the \
FBO should fail and then also return?</p></div></div> <div style="margin: 8px 0; \
padding: 0 12px;"><p style="padding: 0; margin: 8px;">Changing the rendering \
doesn't block making calls to any of the openGL calls in QtBase. <br /> The \
only changes are purely inside QtQuick</p>
<p style="padding: 0; margin: 8px;">So:<br />
creating a context still works fine<br />
creating an FBO still works fine</p>
<p style="padding: 0; margin: 8px;">why m_view->setRenderTarget and \
m_view->resetOpenGLState still work are the more interesting questions<br /> but \
that's because they're virtual methods that no-op.</p>
<p style="padding: 0; margin: 8px;">With this code:<br />
we create an OpenGL context<br />
set it to be active<br />
then ignore it and do something completely different with QPainter \
instead</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8039" \
rel="noreferrer">https://phabricator.kde.org/D8039</a></div></div><br \
/><div><strong>To: </strong>davidedmundson, Plasma<br /><strong>Cc: \
</strong>graesslin, apol, plasma-devel, kwin, KWin, bwowk, ZrenBot, progwolff, \
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, mart<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic