--c59fb0b198ec4c9d8515096057d975ed
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="ascii"
Mime-Version: 1.0
davidedmundson added inline comments.
INLINE COMMENTS
> apol wrote in aurorae.cpp:344
> `#if QT_VERSION < QT_VERSION_CHECK(5,10,0)`?
Yeah, makes sense, it got +2'd quicker than I expected.
> graesslin wrote in aurorae.cpp:354
> stupid question: but why is this code working? I would assume that making the context current will fail here and then we return? And even if the creation of the FBO should fail and then also return?
Changing the rendering doesn't block making calls to any of the openGL calls in QtBase.
The only changes are purely inside QtQuick
So:
creating a context still works fine
creating an FBO still works fine
why m_view->setRenderTarget and m_view->resetOpenGLState still work are the more interesting questions
but that's because they're virtual methods that no-op.
With this code:
we create an OpenGL context
set it to be active
then ignore it and do something completely different with QPainter instead
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D8039
To: davidedmundson, #plasma
Cc: graesslin, apol, plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, mart
--c59fb0b198ec4c9d8515096057d975ed
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html; charset="ascii"
Mime-Version: 1.0
INLINE COMMENTS
#if QT_VERSION < QT_VERSION_CHECK(5,10,0)?
Yeah, makes sense, it got +2'd quicker than I expected.
<=
/div>
stupid question: but why is this code working? I =
would assume that making the context current will fail here and then we ret=
urn? And even if the creation of the FBO should fail and then also return?<=
/p>
Changing the rendering doesn't block making calls to any of =
the openGL calls in QtBase.
The only changes are purely inside QtQuick
So:
creating a context still works fine
creating an FBO still works fine
why m_view->setRenderTarget and m_=
view->resetOpenGLState still work are the more interesting questions
but that's because they're virtual methods that no-op.
With this code:
we create an OpenGL context
set it to be active
then ignore it and do something completely different with QPainter instead<=
/p>
To: davidedmundson, Plasma
Cc: graesslin, apol, plasma-=
devel, kwin, KWin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hard=
ening, jensreuterberg, abetts, sebas, mart
--c59fb0b198ec4c9d8515096057d975ed--