[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D8014: Don't animate IconItem in software mode
From:       Marco Martin <noreply () phabricator ! kde ! org>
Date:       2017-09-29 9:30:30
Message-ID: 20170929093030.99982.2947301701289C73 () phabricator ! kde ! org
[Download RAW message or body]

mart added inline comments.

INLINE COMMENTS

> iconitem.cpp:624
> +
> +    if (QQuickWindow::sceneGraphBackend() == QLatin1String("software")) {
> +        animated = false;

enclose this part with #ifdef on Qt version?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D8014

To: davidedmundson, #plasma, broulik, bcooksley
Cc: mart, bcooksley, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol


[Attachment #3 (unknown)]

<table><tr><td style="">mart added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D8014" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D8014#inline-33491" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">iconitem.cpp:624</span></div> <div style="font: 11px/15px &quot;Menlo&quot;, \
&quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">if</span> \
<span class="p">(</span><span class="n">QQuickWindow</span><span style="color: \
#aa2211">::</span><span class="n">sceneGraphBackend</span><span class="p">()</span> \
<span style="color: #aa2211">==</span> <span class="n">QLatin1String</span><span \
class="p">(</span><span style="color: #766510">&quot;software&quot;</span><span \
class="p">))</span> <span class="p">{</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span \
class="n">animated</span> <span style="color: #aa2211">=</span> <span style="color: \
#304a96">false</span><span class="p">;</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">enclose this part with #ifdef on Qt \
version?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework \
(Library)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8014" \
rel="noreferrer">https://phabricator.kde.org/D8014</a></div></div><br \
/><div><strong>To: </strong>davidedmundson, Plasma, broulik, bcooksley<br \
/><strong>Cc: </strong>mart, bcooksley, plasma-devel, Frameworks, ZrenBot, progwolff, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]